mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org, patrick.bellasi@arm.com,
	juri.lelli@arm.com, andresoportus@google.com,
	dietmar.eggemann@arm.com,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Len Brown <lenb@kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient
Date: Tue, 11 Jul 2017 13:40:34 +0200	[thread overview]
Message-ID: <20170711114034.aamhq332wusj3irj@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170709170826.29396-1-joelaf@google.com>

On Sun, Jul 09, 2017 at 10:08:26AM -0700, Joel Fernandes wrote:
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -53,7 +53,9 @@ struct sugov_cpu {
>  	struct update_util_data update_util;
>  	struct sugov_policy *sg_policy;
>  
> +	bool prev_iowait_boost;
>  	unsigned long iowait_boost;


So I absolutely detest 'bool' in composite types, but I see there's
already some of that in this file :/

      parent reply	other threads:[~2017-07-11 11:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09 17:08 Joel Fernandes
2017-07-10 10:55 ` Juri Lelli
2017-07-11  5:12   ` Joel Fernandes
2017-07-11  7:14     ` Juri Lelli
2017-07-11 14:33       ` Joel Fernandes
2017-07-11 14:38         ` Juri Lelli
2017-07-11 10:14 ` Viresh Kumar
2017-07-11 11:39   ` Peter Zijlstra
2017-07-11 14:14   ` Joel Fernandes
2017-07-11 14:18     ` Joel Fernandes
2017-07-12  5:00     ` Viresh Kumar
2017-07-12  9:36       ` Peter Zijlstra
2017-07-12  9:46         ` Viresh Kumar
2017-07-12 13:28           ` Peter Zijlstra
2017-07-13  3:42             ` Viresh Kumar
2017-07-13  2:02       ` Joel Fernandes
2017-07-13  3:35         ` Viresh Kumar
2017-07-13  3:52           ` Joel Fernandes
2017-07-13  4:14             ` Viresh Kumar
2017-07-13  4:16               ` Joel Fernandes
2017-07-11 11:40 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170711114034.aamhq332wusj3irj@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andresoportus@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelaf@google.com \
    --cc=juri.lelli@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=patrick.bellasi@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®