From: Peter Zijlstra <peterz@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Joel Fernandes <joelaf@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Juri Lelli <juri.lelli@arm.com>,
Andres Oportus <andresoportus@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient
Date: Wed, 12 Jul 2017 15:28:24 +0200 [thread overview]
Message-ID: <20170712132824.mnoevjtm6wd6yh2c@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170712094623.GE1679@vireshk-i7>
On Wed, Jul 12, 2017 at 03:16:23PM +0530, Viresh Kumar wrote:
> No, I wasn't clear enough. Sorry about that. Lemme try again:
>
> Suppose min freq is 500 MHz and Max is 2 GHz. The iowait-boost is
> set to 1 GHz right now (because of previous events with IOWAIT flag
> set), and sugov_set_iowait_boost() gets called again with IOWAIT flag,
> we boost the iowait-boost value to 2 GHz. We are in the rate_limit_us
> window right now, we return without changing the frequency.
>
> If the next call into the schedutil governor happens due to normal
> util-update, flags will be passed as 0. With the current patch, we
> will bring iowait-boost back to 1 GHz (before updating the real
> frequency to 2 GHz) as the prev-iowait-boost boolean would be set.
>
> And even if the task is periodically getting queued after IOWAIT,
> actual boosting may not happen at all in some cases.
Hmm, so you're worried about that ratelimit stuff? Shouldn't we fix that
independently -- IIRC Rafael proposed a max-filter over the window.
next prev parent reply other threads:[~2017-07-12 13:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 17:08 Joel Fernandes
2017-07-10 10:55 ` Juri Lelli
2017-07-11 5:12 ` Joel Fernandes
2017-07-11 7:14 ` Juri Lelli
2017-07-11 14:33 ` Joel Fernandes
2017-07-11 14:38 ` Juri Lelli
2017-07-11 10:14 ` Viresh Kumar
2017-07-11 11:39 ` Peter Zijlstra
2017-07-11 14:14 ` Joel Fernandes
2017-07-11 14:18 ` Joel Fernandes
2017-07-12 5:00 ` Viresh Kumar
2017-07-12 9:36 ` Peter Zijlstra
2017-07-12 9:46 ` Viresh Kumar
2017-07-12 13:28 ` Peter Zijlstra [this message]
2017-07-13 3:42 ` Viresh Kumar
2017-07-13 2:02 ` Joel Fernandes
2017-07-13 3:35 ` Viresh Kumar
2017-07-13 3:52 ` Joel Fernandes
2017-07-13 4:14 ` Viresh Kumar
2017-07-13 4:16 ` Joel Fernandes
2017-07-11 11:40 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712132824.mnoevjtm6wd6yh2c@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andresoportus@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@arm.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®