From: kbuild test robot <lkp@intel.com>
To: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Cc: kbuild-all@01.org, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, hare@suse.de,
bart.vanassche@sandisk.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: scsi_dh_alua: fix boolreturn.cocci warnings
Date: Tue, 11 Jul 2017 22:11:43 +0800 [thread overview]
Message-ID: <20170711141143.GA7961@intel11.lkp.intel.com> (raw)
In-Reply-To: <1499726857-7875-4-git-send-email-mauricfo@linux.vnet.ibm.com>
drivers/scsi/device_handler/scsi_dh_alua.c:594:9-10: WARNING: return of 0/1 in function 'alua_rtpg_print_check' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: cb809ba2fcbf ("scsi: scsi_dh_alua: do not print RTPG state if it remains unavailable/standby")
CC: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
scsi_dh_alua.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -591,7 +591,7 @@ static bool alua_rtpg_print_check(int ol
case SCSI_ACCESS_STATE_STANDBY:
return old_state != new_state;
default:
- return 1;
+ return true;
}
}
next prev parent reply other threads:[~2017-07-11 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 22:47 [PATCH v2 0/4] scsi_dh_alua: fix stuck I/O after unavailable/standby states Mauricio Faria de Oliveira
2017-07-10 22:47 ` [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port unavailable and standby states Mauricio Faria de Oliveira
2017-07-11 9:18 ` Hannes Reinecke
2017-07-11 15:32 ` Mauricio Faria de Oliveira
2017-07-11 21:01 ` Mauricio Faria de Oliveira
2017-07-10 22:47 ` [PATCH v2 2/4] scsi: scsi_dh_alua: print changes to RTPG state of all PGs Mauricio Faria de Oliveira
2017-07-10 22:47 ` [PATCH v2 3/4] scsi: scsi_dh_alua: do not print RTPG state if it remains unavailable/standby Mauricio Faria de Oliveira
2017-07-11 14:11 ` kbuild test robot [this message]
2017-07-11 14:11 ` kbuild test robot
2017-07-10 22:47 ` [PATCH v2 4/4] scsi: scsi_dh_alua: add sdev_dbg() to track alua_rtpg_work() Mauricio Faria de Oliveira
2017-07-10 22:53 ` [PATCH v2 0/4] scsi_dh_alua: fix stuck I/O after unavailable/standby states Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711141143.GA7961@intel11.lkp.intel.com \
--to=lkp@intel.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mauricfo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®