From: Ismael Luceno <ismael@iodev.co.uk>
To: Colin King <colin.king@canonical.com>
Cc: Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
Anton Sviridenko <anton@corp.bluecherry.net>,
Andrey Utkin <andrey.utkin@corp.bluecherry.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static
Date: Tue, 11 Jul 2017 15:56:58 -0300 [thread overview]
Message-ID: <20170711185657.GC11785@pirotess.bf.iodev.co.uk> (raw)
In-Reply-To: <20170710185103.18461-1-colin.king@canonical.com>
On 10/Jul/2017 19:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
> it static. Makes the object code smaller and saves nearly 840 bytes
>
> Before:
> text data bss dec hex filename
> 9218 360 0 9578 256a solo6x10-tw28.o
>
> After:
> text data bss dec hex filename
> 8237 504 0 8741 2225 solo6x10-tw28.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-tw28.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c
> index 0632d3f7c73c..1c013a03d851 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-tw28.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-tw28.c
> @@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals,
> static void saa712x_setup(struct solo_dev *dev)
> {
> const int reg_start = 0x26;
> - const u8 saa7128_regs_ntsc[] = {
> + static const u8 saa7128_regs_ntsc[] = {
> /* :0x26 */
> 0x0d, 0x00,
> /* :0x28 */
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
prev parent reply other threads:[~2017-07-11 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 18:51 Colin King
2017-07-11 17:54 ` Andrey Utkin
2017-07-11 18:56 ` Ismael Luceno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711185657.GC11785@pirotess.bf.iodev.co.uk \
--to=ismael@iodev.co.uk \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=anton@corp.bluecherry.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®