From: Scott Wood <swood@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Scott Wood <swood@redhat.com>
Subject: [PATCH 1/8] ktest: Clarify config file usage
Date: Sun, 16 Jul 2017 19:16:23 -0500 [thread overview]
Message-ID: <20170717001630.10518-1-swood@redhat.com> (raw)
Simply telling a new user to edit "the config file" without giving any
hints on where that file should go, what it should be named, or where
a template can be found, is not particularly helpful.
Signed-off-by: Scott Wood <swood@redhat.com>
---
tools/testing/ktest/ktest.pl | 3 ++-
tools/testing/ktest/sample.conf | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 0c8b61f8398e..cdf6974bc462 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -1140,7 +1140,8 @@ sub __read_config {
sub get_test_case {
print "What test case would you like to run?\n";
print " (build, install or boot)\n";
- print " Other tests are available but require editing the config file\n";
+ print " Other tests are available but require editing ktest.conf\n";
+ print " (see tools/testing/ktest/sample.conf)\n";
my $ans = <STDIN>;
chomp $ans;
$default{"TEST_TYPE"} = $ans;
diff --git a/tools/testing/ktest/sample.conf b/tools/testing/ktest/sample.conf
index 6c58cd8bbbae..7636236b87d3 100644
--- a/tools/testing/ktest/sample.conf
+++ b/tools/testing/ktest/sample.conf
@@ -1,6 +1,9 @@
#
# Config file for ktest.pl
#
+# Place your customized version of this, named ktest.conf, in the
+# working directory that ktest.pl is run from.
+#
# Note, all paths must be absolute
#
--
2.9.4
next reply other threads:[~2017-07-17 0:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 0:16 Scott Wood [this message]
2017-07-17 0:16 ` [PATCH 2/8] ktest: Set buildonly=1 for CONFIG_BISECT_TYPE=build Scott Wood
2017-07-17 0:16 ` [PATCH 3/8] ktest: Set do_not_reboot=y " Scott Wood
2017-07-17 0:16 ` [PATCH 4/8] ktest: Separate out config bisect logic Scott Wood
2017-07-17 0:16 ` [PATCH 5/8] ktest/config_bisect: Simplify " Scott Wood
2017-07-17 0:16 ` [PATCH 6/8] ktest/config-bisect: Try harder to find a new config Scott Wood
2017-07-17 0:16 ` [PATCH 7/8] ktest: Add simple config-bisect frontend Scott Wood
2017-07-17 0:16 ` [PATCH 8/8] ktest: Use config-bisect.pl in ktest.pl Scott Wood
2017-09-14 21:41 ` Scott Wood
2017-10-04 19:17 ` Steven Rostedt
2017-10-04 19:18 ` Steven Rostedt
2017-10-04 20:24 ` Scott Wood
2017-10-05 12:50 ` Steven Rostedt
2017-10-05 23:18 ` Scott Wood
2017-10-05 19:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717001630.10518-1-swood@redhat.com \
--to=swood@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®