mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
	mchehab@kernel.org, jikos@kernel.org
Subject: Re: [patch 0/2] add actuators support
Date: Mon, 17 Jul 2017 18:28:38 +0200	[thread overview]
Message-ID: <20170717162838.GF9786@kroah.com> (raw)
In-Reply-To: <20170717161914.5043-1-jiri@resnulli.us>

On Mon, Jul 17, 2017 at 06:19:12PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> I am owner of height adjustable desk and naturally, as it has an USB
> interface, I need to controll it from my computer. Started to think
> about what would be the best way, I realized that I need to introduce
> a new driver class in kernel. The reason is a need to have one API
> for all possible kinds of actuator devices (USB, I2C, gpio, etc).

Why does this have to be a kernel driver at all?  Your USB driver should
really just be a simple userspace application (use libusb to have it
work on all operating systems.)

While the idea of a "generic class" is nice, given that there is only
one device of this type out there so far, and it's a USB one, kind of
implies that a generic class isn't needed just yet.

Oh, and it's nice to cc: the linux-usb@vger mailing list for USB patches
in the future :)

thanks,

greg k-h

  parent reply	other threads:[~2017-07-17 16:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 16:19 Jiri Pirko
2017-07-17 16:19 ` [patch 1/2] add support for generic actuator devices Jiri Pirko
2017-07-17 16:19 ` [patch 2/2] actuator: introduce Linak USB2LIN cable support Jiri Pirko
2017-07-17 16:28 ` Greg KH [this message]
2017-07-17 16:34   ` [patch 0/2] add actuators support Jiri Pirko
2017-07-17 16:40     ` Greg KH
2017-07-17 16:48       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170717162838.GF9786@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=jikos@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®