* [PATCH] staging: iio: adc: add space around substraction operation
@ 2017-07-18 5:38 Hari Prasath
2017-07-18 5:57 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Hari Prasath @ 2017-07-18 5:38 UTC (permalink / raw)
To: lars
Cc: gehariprasath, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
linux-iio, devel, linux-kernel
Fix checkpatch warning to add space around the substraction operation
Signed-off-by: Hari Prasath <gehariprasath@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index d5ab83f..d79e774 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
}
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
+ in_voltage - voltage_thresh_low_value,
0644,
ad7280_read_channel_config,
ad7280_write_channel_config,
AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
+ in_voltage - voltage_thresh_high_value,
0644,
ad7280_read_channel_config,
ad7280_write_channel_config,
--
2.10.0.GIT
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: adc: add space around substraction operation
2017-07-18 5:38 [PATCH] staging: iio: adc: add space around substraction operation Hari Prasath
@ 2017-07-18 5:57 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-07-18 5:57 UTC (permalink / raw)
To: Hari Prasath, lars
Cc: gehariprasath, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
linux-iio, devel, linux-kernel
On 18 July 2017 06:38:08 BST, Hari Prasath <gehariprasath@gmail.com> wrote:
>Fix checkpatch warning to add space around the substraction operation
>
>Signed-off-by: Hari Prasath <gehariprasath@gmail.com>
>---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/iio/adc/ad7280a.c
>b/drivers/staging/iio/adc/ad7280a.c
>index d5ab83f..d79e774 100644
>--- a/drivers/staging/iio/adc/ad7280a.c
>+++ b/drivers/staging/iio/adc/ad7280a.c
>@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
>void *private)
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
>- in_voltage-voltage_thresh_low_value,
>+ in_voltage - voltage_thresh_low_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
> AD7280A_CELL_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
>- in_voltage-voltage_thresh_high_value,
>+ in_voltage - voltage_thresh_high_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
Check what this code actually does.
Using checkpatch gives suggestions of where
to look for issues; it is not always right!
This change breaks the userspace ABI.
Jonathan
Ps when ever I see a patch involving whitespace and this driver I know I am going to give roughly
this response having done so perhaps 10 times in the past!
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-18 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 5:38 [PATCH] staging: iio: adc: add space around substraction operation Hari Prasath
2017-07-18 5:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®