* [PATCH v3 0/1] Staging: android/ion: fix sparse warnings
@ 2017-07-15 11:43 Joseph Wright
2017-07-15 11:43 ` [PATCH v3 1/1] Staging: android/ion: declare function static Joseph Wright
0 siblings, 1 reply; 4+ messages in thread
From: Joseph Wright @ 2017-07-15 11:43 UTC (permalink / raw)
To: gregkh, arve, riandrews; +Cc: devel, linux-kernel, Joseph Wright
Improve commit message.
Previous version included a patch to add declarations to ion.h, but I
have dropped that as the same declarations were recently removed.
Joseph Wright (1):
Staging: android/ion: declare function static
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/1] Staging: android/ion: declare function static
2017-07-15 11:43 [PATCH v3 0/1] Staging: android/ion: fix sparse warnings Joseph Wright
@ 2017-07-15 11:43 ` Joseph Wright
2017-07-18 6:58 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Joseph Wright @ 2017-07-15 11:43 UTC (permalink / raw)
To: gregkh, arve, riandrews; +Cc: devel, linux-kernel, Joseph Wright
Declare private function static to fix sparse warning:
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?
Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
---
Changes in v3:
- Make subject clearer
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
return &cma_heap->heap;
}
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
{
struct ion_heap *heap;
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 1/1] Staging: android/ion: declare function static
2017-07-15 11:43 ` [PATCH v3 1/1] Staging: android/ion: declare function static Joseph Wright
@ 2017-07-18 6:58 ` Greg KH
2017-07-18 15:00 ` Joseph Wright
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2017-07-18 6:58 UTC (permalink / raw)
To: Joseph Wright; +Cc: arve, riandrews, devel, linux-kernel
On Sat, Jul 15, 2017 at 11:43:05AM +0000, Joseph Wright wrote:
> Declare private function static to fix sparse warning:
>
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> was not declared. Should it be static?
>
> Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
> ---
> Changes in v3:
> - Make subject clearer
>
> drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sorry, does not apply to my tree as I think someone else already did
this before you did :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/1] Staging: android/ion: declare function static
2017-07-18 6:58 ` Greg KH
@ 2017-07-18 15:00 ` Joseph Wright
0 siblings, 0 replies; 4+ messages in thread
From: Joseph Wright @ 2017-07-18 15:00 UTC (permalink / raw)
To: Greg KH; +Cc: arve, riandrews, devel, linux-kernel
On Tue, Jul 18, 2017 at 08:58:22AM +0200, Greg KH wrote:
> On Sat, Jul 15, 2017 at 11:43:05AM +0000, Joseph Wright wrote:
> > Declare private function static to fix sparse warning:
> >
> > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> > was not declared. Should it be static?
> >
> > Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
> > ---
> > Changes in v3:
> > - Make subject clearer
> >
> > drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Sorry, does not apply to my tree as I think someone else already did
> this before you did :(
Okay, thanks anyway.
Joseph
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-18 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-15 11:43 [PATCH v3 0/1] Staging: android/ion: fix sparse warnings Joseph Wright
2017-07-15 11:43 ` [PATCH v3 1/1] Staging: android/ion: declare function static Joseph Wright
2017-07-18 6:58 ` Greg KH
2017-07-18 15:00 ` Joseph Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome