mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexei Potashnik <alexei@purestorage.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: doc change for ST behavior on NUMA systems
Date: Tue, 18 Jul 2017 15:36:15 -0400	[thread overview]
Message-ID: <20170718193615.GB3365493@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170718191829.GA11583@infradead.org>

On Tue, Jul 18, 2017 at 12:18:29PM -0700, Christoph Hellwig wrote:
> On Tue, Jul 18, 2017 at 11:12:53AM -0700, Alexei Potashnik wrote:
> > NUMA rework of workqueue made the combination of max_active of 1 and
> > WQ_UNBOUND insufficient to guarantee ST behavior system wide.
> > 
> > alloc_ordered_queue should now be used instead.
> 
> Eww.  And how many existing users might be broken by that?

Good point.  create_singlethread_workqueue() maps to
alloc_ordered_workqueue(), so they're all good.  Only the ones which
got converted to the new interface incorrectly would be broken.  I
probably should make WQ_UNBOUND / 1 behave as ordered.  I'll think
more about it.

Thanks!

-- 
tejun

  reply	other threads:[~2017-07-18 19:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 18:12 Alexei Potashnik
2017-07-18 18:37 ` Tejun Heo
2017-07-18 19:18 ` Christoph Hellwig
2017-07-18 19:36   ` Tejun Heo [this message]
2017-07-18 21:32   ` Alexei Potashnik
2017-07-18 22:25   ` Alexei Potashnik
2017-07-18 22:41   ` [PATCH wq/for-4.13-fixes] workqueue: restore WQ_UNBOUND/max_active==1 to be ordered Tejun Heo
2017-07-19 15:25     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718193615.GB3365493@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=alexei@purestorage.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome