mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexei Potashnik <alexei@purestorage.com>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] workqueue: doc change for ST behavior on NUMA systems
Date: Tue, 18 Jul 2017 11:12:53 -0700	[thread overview]
Message-ID: <aacf48f5db89f6f2336f1a4463ae3a24@mail.gmail.com> (raw)

NUMA rework of workqueue made the combination of max_active of 1 and
WQ_UNBOUND insufficient to guarantee ST behavior system wide.

alloc_ordered_queue should now be used instead.

Signed-off-by: Alexei Potashnik <alexei@purestorage.com>
---
 Documentation/core-api/workqueue.rst | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/core-api/workqueue.rst
b/Documentation/core-api/workqueue.rst
index ffdec94..3943b5b 100644
--- a/Documentation/core-api/workqueue.rst
+++ b/Documentation/core-api/workqueue.rst
@@ -243,11 +243,15 @@ throttling the number of active work items,
specifying '0' is
 recommended.

 Some users depend on the strict execution ordering of ST wq.  The
-combination of ``@max_active`` of 1 and ``WQ_UNBOUND`` is used to
-achieve this behavior.  Work items on such wq are always queued to the
-unbound worker-pools and only one work item can be active at any given
+combination of ``@max_active`` of 1 and ``WQ_UNBOUND`` used to
+achieve this behavior.  Work items on such wq were always queued to the
+unbound worker-pools and only one work item could be active at any given
 time thus achieving the same ordering property as ST wq.

+In the current implementation the above configuration only guarantees
+ST behavior within a given NUMA node. Instead alloc_ordered_queue should
+be used to achieve system wide ST behavior.
+

 Example Execution Scenarios
 ===========================
-- 
1.9.1

             reply	other threads:[~2017-07-18 18:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 18:12 Alexei Potashnik [this message]
2017-07-18 18:37 ` Tejun Heo
2017-07-18 19:18 ` Christoph Hellwig
2017-07-18 19:36   ` Tejun Heo
2017-07-18 21:32   ` Alexei Potashnik
2017-07-18 22:25   ` Alexei Potashnik
2017-07-18 22:41   ` [PATCH wq/for-4.13-fixes] workqueue: restore WQ_UNBOUND/max_active==1 to be ordered Tejun Heo
2017-07-19 15:25     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aacf48f5db89f6f2336f1a4463ae3a24@mail.gmail.com \
    --to=alexei@purestorage.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome