mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled
@ 2017-07-19  1:20 David Carrillo-Cisneros
  0 siblings, 0 replies; 2+ messages in thread
From: David Carrillo-Cisneros @ 2017-07-19  1:20 UTC (permalink / raw)
  To: linux-kernel, Arnaldo Carvalho de Melo, Jiri Olsa
  Cc: Kees Kook, Sudeep Holla, Alexander Shishkin, Wang Nan,
	Elena Reshetova, Stephane Eranian, Paul Turner, Peter Zijlstra,
	Ingo Molnar, Sudeep Holla

From: Sudeep Holla <Sudeep.Holla@arm.com>

When libelf is disabled in the configuration, we get the following
linker error:
  LINK     libperf-jvmti.so
  ld: cannot find -lelf
  Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed

Jiri pointed out that both librt and libelf are not really required. So
this patch fixes the linker error by getting rid of unwanted libraries
in the linker stage.

Fixes: 209045adc2bb ("perf tools: add JVMTI agent library")
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 100a6c1670c8..d66f90e6be5c 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -518,7 +518,7 @@ $(LIBJVMTI_IN): FORCE
 	$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti
 
 $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
-	$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
+	$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $<
 endif
 
 $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
-- 
2.13.2.932.g7449e964c-goog

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH 0/4] Resubmitted forgotten patches
@ 2017-07-19  1:18 David Carrillo-Cisneros
  2017-07-19  1:18 ` [PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled David Carrillo-Cisneros
  0 siblings, 1 reply; 2+ messages in thread
From: David Carrillo-Cisneros @ 2017-07-19  1:18 UTC (permalink / raw)
  To: linux-kernel, Arnaldo Carvalho de Melo, Jiri Olsa
  Cc: Kees Kook, Sudeep Holla, Alexander Shishkin, Wang Nan,
	Elena Reshetova, Stephane Eranian, Paul Turner,
	David Carrillo-Cisneros

Pickup some small fixes that have been forgotten.

David Carrillo-Cisneros (3):
  perf tool cgroup: Initialize cgroup refcnt with refcount_set
  perf tools: Add EXCLUDE_EXTLIBS and EXTRA_PERFLIBS to makefile
  perf annotate: Process tracing data in pipe mode

Sudeep Holla (1):
  tools: perf: Fix linker error when libelf config is disabled

 tools/perf/Makefile.perf      | 10 ++++++++--
 tools/perf/builtin-annotate.c |  1 +
 tools/perf/util/cgroup.c      |  5 ++++-
 3 files changed, 13 insertions(+), 3 deletions(-)

-- 
2.13.2.932.g7449e964c-goog

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-19  1:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-19  1:20 [PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled David Carrillo-Cisneros
  -- strict thread matches above, loose matches on Subject: below --
2017-07-19  1:18 [PATCH 0/4] Resubmitted forgotten patches David Carrillo-Cisneros
2017-07-19  1:18 ` [PATCH 4/4] tools: perf: Fix linker error when libelf config is disabled David Carrillo-Cisneros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome