* [PATCH 2/2] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission
@ 2017-07-18 7:23 Jaya Durga
2017-07-19 11:51 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jaya Durga @ 2017-07-18 7:23 UTC (permalink / raw)
To: gregkh
Cc: jic23, knaack.h, lars, pmeerw, singhalsimran0, eraretuya,
linux-iio, devel, linux-kernel, Jaya Durga
Replace symbolic permissions with their
octect representation to fix checkpatch warnings.
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
index af3910b..c63fe6a 100644
--- a/drivers/staging/iio/light/tsl2x7x_core.c
+++ b/drivers/staging/iio/light/tsl2x7x_core.c
@@ -1498,34 +1498,34 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
return 0;
}
-static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(power_state, 0644,
tsl2x7x_power_state_show, tsl2x7x_power_state_store);
-static DEVICE_ATTR(in_proximity0_calibscale_available, S_IRUGO,
+static DEVICE_ATTR(in_proximity0_calibscale_available, 0444,
tsl2x7x_prox_gain_available_show, NULL);
-static DEVICE_ATTR(in_illuminance0_calibscale_available, S_IRUGO,
+static DEVICE_ATTR(in_illuminance0_calibscale_available, 0444,
tsl2x7x_gain_available_show, NULL);
-static DEVICE_ATTR(in_illuminance0_integration_time, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_illuminance0_integration_time, 0644,
tsl2x7x_als_time_show, tsl2x7x_als_time_store);
-static DEVICE_ATTR(in_illuminance0_target_input, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_illuminance0_target_input, 0644,
tsl2x7x_als_cal_target_show, tsl2x7x_als_cal_target_store);
-static DEVICE_ATTR(in_illuminance0_calibrate, S_IWUSR, NULL,
+static DEVICE_ATTR(in_illuminance0_calibrate, 0200, NULL,
tsl2x7x_do_calibrate);
-static DEVICE_ATTR(in_proximity0_calibrate, S_IWUSR, NULL,
+static DEVICE_ATTR(in_proximity0_calibrate, 0200, NULL,
tsl2x7x_do_prox_calibrate);
-static DEVICE_ATTR(in_illuminance0_lux_table, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_illuminance0_lux_table, 0644,
tsl2x7x_luxtable_show, tsl2x7x_luxtable_store);
-static DEVICE_ATTR(in_intensity0_thresh_period, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_intensity0_thresh_period, 0644,
tsl2x7x_als_persistence_show, tsl2x7x_als_persistence_store);
-static DEVICE_ATTR(in_proximity0_thresh_period, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_proximity0_thresh_period, 0644,
tsl2x7x_prox_persistence_show, tsl2x7x_prox_persistence_store);
/* Use the default register values to identify the Taos device */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission
2017-07-18 7:23 [PATCH 2/2] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission Jaya Durga
@ 2017-07-19 11:51 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-07-19 11:51 UTC (permalink / raw)
To: Jaya Durga
Cc: jic23, knaack.h, lars, pmeerw, singhalsimran0, eraretuya,
linux-iio, devel, linux-kernel
On Tue, Jul 18, 2017 at 12:53:23PM +0530, Jaya Durga wrote:
> Replace symbolic permissions with their
> octect representation to fix checkpatch warnings.
>
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Where is patch 1 of this series?
Again, please fix and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-19 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 7:23 [PATCH 2/2] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission Jaya Durga
2017-07-19 11:51 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®