From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Colin King <colin.king@canonical.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
Date: Thu, 20 Jul 2017 11:15:38 +0200 [thread overview]
Message-ID: <20170720091538.GB27647@kroah.com> (raw)
In-Reply-To: <20170720085236.xwer2iatjl5vjta6@gmail.com>
On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
>
> * Colin King <colin.king@canonical.com> wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Add in missing void return type, fixes sparse warning:
> > "warning: 'hyperv_cleanup()' has implicit return type"
> >
> > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/x86/include/asm/mshyperv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > index 01b9c0fb3aab..41fae263f8fa 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > #else /* CONFIG_HYPERV */
> > static inline void hyperv_init(void) {}
> > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > -static inline hyperv_cleanup(void) {}
> > +static inline void hyperv_cleanup(void) {}
> > #endif /* CONFIG_HYPERV */
>
> Guys, Greg, could we please move this commit from the drivers tree:
>
> 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
>
> arch/x86/Kbuild | 2 +-
> arch/x86/include/asm/mshyperv.h | 7 ++++++-
>
> ... to the x86 tree where it belongs?
I've now reverted it from my tree entirely, sorry about that.
greg k-h
next prev parent reply other threads:[~2017-07-20 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170719090859.9248-1-colin.king@canonical.com>
2017-07-20 8:52 ` Ingo Molnar
2017-07-20 9:15 ` Greg Kroah-Hartman [this message]
2017-07-20 9:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720091538.GB27647@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®