From: Benjamin Poirier <bpoirier@suse.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] e1000e: Fix wrong comment related to link detection
Date: Fri, 21 Jul 2017 11:36:24 -0700 [thread overview]
Message-ID: <20170721183627.13373-2-bpoirier@suse.com> (raw)
In-Reply-To: <20170721183627.13373-1-bpoirier@suse.com>
Reading e1000e_check_for_copper_link() shows that get_link_status is set to
false after link has been detected. Therefore, it stays TRUE until then.
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 2dcb5463d9b8..58a87134d2e5 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -5074,7 +5074,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
/* get_link_status is set on LSC (link status) interrupt or
* Rx sequence error interrupt. get_link_status will stay
- * false until the check_for_link establishes link
+ * true until the check_for_link establishes link
* for copper adapters ONLY
*/
switch (hw->phy.media_type) {
@@ -5092,7 +5092,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
break;
case e1000_media_type_internal_serdes:
ret_val = hw->mac.ops.check_for_link(hw);
- link_active = adapter->hw.mac.serdes_has_link;
+ link_active = hw->mac.serdes_has_link;
break;
default:
case e1000_media_type_unknown:
--
2.13.2
next prev parent reply other threads:[~2017-07-21 18:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 14:21 commit 16ecba59 breaks 82574L under heavy load Lennart Sorensen
2017-07-18 23:14 ` Benjamin Poirier
2017-07-19 14:19 ` Lennart Sorensen
2017-07-20 0:07 ` Benjamin Poirier
2017-07-20 14:00 ` Lennart Sorensen
2017-07-20 23:44 ` Benjamin Poirier
2017-07-21 15:27 ` Lennart Sorensen
2017-07-21 16:09 ` Lennart Sorensen
2017-07-21 18:36 ` [PATCH 1/5] e1000e: Fix error path in link detection Benjamin Poirier
2017-07-21 18:36 ` Benjamin Poirier [this message]
2017-09-19 0:13 ` [Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment related to " Brown, Aaron F
2017-07-21 18:36 ` [PATCH 3/5] e1000e: Fix return value test Benjamin Poirier
2017-09-15 0:20 ` [Intel-wired-lan] " Brown, Aaron F
2017-07-21 18:36 ` [PATCH 4/5] e1000e: Separate signaling for link check/link up Benjamin Poirier
2017-07-21 18:50 ` Lennart Sorensen
2017-08-02 11:28 ` [Intel-wired-lan] " Neftin, Sasha
2017-08-02 14:34 ` Lennart Sorensen
2017-08-02 14:49 ` Benjamin Poirier
2017-09-15 0:27 ` Brown, Aaron F
2017-07-21 18:36 ` [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts Benjamin Poirier
2017-07-21 18:48 ` Lennart Sorensen
2017-08-12 2:13 ` Philip Prindeville
2017-08-12 2:47 ` Philip Prindeville
2017-08-21 17:17 ` Benjamin Poirier
2017-09-15 0:38 ` [Intel-wired-lan] " Brown, Aaron F
2017-09-19 18:38 ` [5/5] " Philip Prindeville
2017-09-19 19:41 ` Benjamin Poirier
2017-10-24 17:20 ` Lennart Sorensen
2017-10-24 17:39 ` Philip Prindeville
2017-09-15 0:18 ` [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection Brown, Aaron F
2017-07-21 19:02 ` commit 16ecba59 breaks 82574L under heavy load Lennart Sorensen
2017-07-24 21:56 ` Philip Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721183627.13373-2-bpoirier@suse.com \
--to=bpoirier@suse.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®