From: Philip Prindeville <philipp_subx@redfish-solutions.com>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: Benjamin Poirier <bpoirier@suse.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts
Date: Fri, 11 Aug 2017 20:47:14 -0600 [thread overview]
Message-ID: <C95AF637-ACAB-4EA9-A287-8DB99A83B830@redfish-solutions.com> (raw)
In-Reply-To: <49B1F3E9-2A99-4AD6-9574-FC3960E67A77@redfish-solutions.com>
> On Aug 11, 2017, at 8:13 PM, Philip Prindeville <philipp_subx@redfish-solutions.com> wrote:
>
>>
>> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen <lsorense@csclub.uwaterloo.ca> wrote:
>>
>> On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote:
>>> When e1000e_poll() is not fast enough to keep up with incoming traffic, the
>>> adapter (when operating in msix mode) raises the Other interrupt to signal
>>> Receiver Overrun.
>>>
>>> This is a double problem because 1) at the moment e1000_msix_other()
>>> assumes that it is only called in case of Link Status Change and 2) if the
>>> condition persists, the interrupt is repeatedly raised again in quick
>>> succession.
>>>
>>> Ideally we would configure the Other interrupt to not be raised in case of
>>> receiver overrun but this doesn't seem possible on this adapter. Instead,
>>> we handle the first part of the problem by reverting to the practice of
>>> reading ICR in the other interrupt handler, like before commit 16ecba59bc33
>>> ("e1000e: Do not read ICR in Other interrupt"). Thanks to commit
>>> 0a8047ac68e5 ("e1000e: Fix msi-x interrupt automask") which cleared IAME
>>> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts
>>> anymore. We handle the second part of the problem by not re-enabling the
>>> Other interrupt right away when there is overrun. Instead, we wait until
>>> traffic subsides, napi polling mode is exited and interrupts are
>>> re-enabled.
>>>
>>> Reported-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
>>> Fixes: 16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt")
>>> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
>>
>> Any chance of this fix hitting -stable? After all adapter reset under
>> load is not nice.
>>
>
>
> I tried this patch sequence and I’m seeing a 2% drop in throughput. CPU utilization at softIRQ is also about 8% higher. The previous single patch that went out to fix this problem had better performance.
>
> This is on an Atom D525 with an 82574L and running 2 GB streams across a pair of interfaces with iperf3.
>
> -Philip
Actually, after turning off MSI-X mode (and using MSI mode instead), and setting InterruptRateThrottle to “4” (conservative dynamic mode) across all interfaces, I’m actually seeing slightly better throughput than the earlier patch… with comparable overall CPU utilization and SoftIRQ utilization.
So setting the module parameters correctly for routing (and not end-system parameters) makes a big difference when routing.
-Philip
next prev parent reply other threads:[~2017-08-12 2:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 14:21 commit 16ecba59 breaks 82574L under heavy load Lennart Sorensen
2017-07-18 23:14 ` Benjamin Poirier
2017-07-19 14:19 ` Lennart Sorensen
2017-07-20 0:07 ` Benjamin Poirier
2017-07-20 14:00 ` Lennart Sorensen
2017-07-20 23:44 ` Benjamin Poirier
2017-07-21 15:27 ` Lennart Sorensen
2017-07-21 16:09 ` Lennart Sorensen
2017-07-21 18:36 ` [PATCH 1/5] e1000e: Fix error path in link detection Benjamin Poirier
2017-07-21 18:36 ` [PATCH 2/5] e1000e: Fix wrong comment related to " Benjamin Poirier
2017-09-19 0:13 ` [Intel-wired-lan] " Brown, Aaron F
2017-07-21 18:36 ` [PATCH 3/5] e1000e: Fix return value test Benjamin Poirier
2017-09-15 0:20 ` [Intel-wired-lan] " Brown, Aaron F
2017-07-21 18:36 ` [PATCH 4/5] e1000e: Separate signaling for link check/link up Benjamin Poirier
2017-07-21 18:50 ` Lennart Sorensen
2017-08-02 11:28 ` [Intel-wired-lan] " Neftin, Sasha
2017-08-02 14:34 ` Lennart Sorensen
2017-08-02 14:49 ` Benjamin Poirier
2017-09-15 0:27 ` Brown, Aaron F
2017-07-21 18:36 ` [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts Benjamin Poirier
2017-07-21 18:48 ` Lennart Sorensen
2017-08-12 2:13 ` Philip Prindeville
2017-08-12 2:47 ` Philip Prindeville [this message]
2017-08-21 17:17 ` Benjamin Poirier
2017-09-15 0:38 ` [Intel-wired-lan] " Brown, Aaron F
2017-09-19 18:38 ` [5/5] " Philip Prindeville
2017-09-19 19:41 ` Benjamin Poirier
2017-10-24 17:20 ` Lennart Sorensen
2017-10-24 17:39 ` Philip Prindeville
2017-09-15 0:18 ` [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection Brown, Aaron F
2017-07-21 19:02 ` commit 16ecba59 breaks 82574L under heavy load Lennart Sorensen
2017-07-24 21:56 ` Philip Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C95AF637-ACAB-4EA9-A287-8DB99A83B830@redfish-solutions.com \
--to=philipp_subx@redfish-solutions.com \
--cc=bpoirier@suse.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®