mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] acpi: add missing include in acpi_numa.h
@ 2017-07-21 22:51 Ross Zwisler
  2017-07-21 22:51 ` [PATCH 2/2] acpi: Fix typo in SRAT table name Ross Zwisler
  0 siblings, 1 reply; 3+ messages in thread
From: Ross Zwisler @ 2017-07-21 22:51 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ross Zwisler, Rafael J. Wysocki, Len Brown, Lv Zheng,
	Robert Moore, devel, linux-acpi

Right now if a file includes acpi_numa.h and they don't happen to include
linux/numa.h before it, they get the following warning:

./include/acpi/acpi_numa.h:9:5: warning: "MAX_NUMNODES" is not defined [-Wundef]
 #if MAX_NUMNODES > 256
     ^~~~~~~~~~~~

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

These two small fixes were previously part of my HMAT enabling series, but
I thought I'd submit them seperately so they don't get held up while I'm
iterating that series.

---
 include/acpi/acpi_numa.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/acpi/acpi_numa.h b/include/acpi/acpi_numa.h
index d4b7294..1e3a74f 100644
--- a/include/acpi/acpi_numa.h
+++ b/include/acpi/acpi_numa.h
@@ -3,6 +3,7 @@
 
 #ifdef CONFIG_ACPI_NUMA
 #include <linux/kernel.h>
+#include <linux/numa.h>
 
 /* Proximity bitmap length */
 #if MAX_NUMNODES > 256
-- 
2.9.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] acpi: Fix typo in SRAT table name
  2017-07-21 22:51 [PATCH 1/2] acpi: add missing include in acpi_numa.h Ross Zwisler
@ 2017-07-21 22:51 ` Ross Zwisler
  2017-07-24 20:29   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Ross Zwisler @ 2017-07-21 22:51 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ross Zwisler, Rafael J. Wysocki, Len Brown, Lv Zheng,
	Robert Moore, devel, linux-acpi

To save someone the time of searching the ACPI spec for "Static Resource
Affinity Table".

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 drivers/acpi/numa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
index edb0c79..917f1cc 100644
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -443,7 +443,7 @@ int __init acpi_numa_init(void)
 	 * So go over all cpu entries in SRAT to get apicid to node mapping.
 	 */
 
-	/* SRAT: Static Resource Affinity Table */
+	/* SRAT: System Resource Affinity Table */
 	if (!acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) {
 		struct acpi_subtable_proc srat_proc[3];
 
-- 
2.9.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] acpi: Fix typo in SRAT table name
  2017-07-21 22:51 ` [PATCH 2/2] acpi: Fix typo in SRAT table name Ross Zwisler
@ 2017-07-24 20:29   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-07-24 20:29 UTC (permalink / raw)
  To: Ross Zwisler
  Cc: linux-kernel, Len Brown, Lv Zheng, Robert Moore, devel, linux-acpi

On Friday, July 21, 2017 04:51:24 PM Ross Zwisler wrote:
> To save someone the time of searching the ACPI spec for "Static Resource
> Affinity Table".
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
>  drivers/acpi/numa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> index edb0c79..917f1cc 100644
> --- a/drivers/acpi/numa.c
> +++ b/drivers/acpi/numa.c
> @@ -443,7 +443,7 @@ int __init acpi_numa_init(void)
>  	 * So go over all cpu entries in SRAT to get apicid to node mapping.
>  	 */
>  
> -	/* SRAT: Static Resource Affinity Table */
> +	/* SRAT: System Resource Affinity Table */
>  	if (!acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) {
>  		struct acpi_subtable_proc srat_proc[3];
>  
> 

Both this and the [1/2] applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-24 20:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-21 22:51 [PATCH 1/2] acpi: add missing include in acpi_numa.h Ross Zwisler
2017-07-21 22:51 ` [PATCH 2/2] acpi: Fix typo in SRAT table name Ross Zwisler
2017-07-24 20:29   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®