* [PATCH] staging: pi433: use IS_ERR to check kthread_run return value
@ 2017-07-22 10:27 Paolo Cretaro
2017-07-22 10:31 ` Paolo Cretaro
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Cretaro @ 2017-07-22 10:27 UTC (permalink / raw)
To: gregkh; +Cc: linux, devel, linux-kernel, Paolo Cretaro
Fix compiler warning: ordered comparison of pointer with integer zero
Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 1bc478a7f49e..79bd19123239 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
device->tx_task_struct = kthread_run(pi433_tx_thread,
device,
"pi433_tx_task");
- if (device->tx_task_struct < 0)
+ if (IS_ERR(device->tx_task_struct))
{
dev_dbg(device->dev, "start of send thread failed");
goto send_thread_failed;
--
2.13.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value
2017-07-22 10:27 [PATCH] staging: pi433: use IS_ERR to check kthread_run return value Paolo Cretaro
@ 2017-07-22 10:31 ` Paolo Cretaro
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Cretaro @ 2017-07-22 10:31 UTC (permalink / raw)
To: gregkh; +Cc: linux, devel, linux-kernel
On 22/07/2017 12:27, Paolo Cretaro wrote:
> Fix compiler warning: ordered comparison of pointer with integer zero
Sorry, just noticed a similar patch has been submitted a few days ago,
please ignore this patch.
Paolo
>
> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 1bc478a7f49e..79bd19123239 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
> device->tx_task_struct = kthread_run(pi433_tx_thread,
> device,
> "pi433_tx_task");
> - if (device->tx_task_struct < 0)
> + if (IS_ERR(device->tx_task_struct))
> {
> dev_dbg(device->dev, "start of send thread failed");
> goto send_thread_failed;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-22 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-22 10:27 [PATCH] staging: pi433: use IS_ERR to check kthread_run return value Paolo Cretaro
2017-07-22 10:31 ` Paolo Cretaro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®