mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Nick Terrell <terrelln@fb.com>
Cc: kbuild-all@01.org, Nick Terrell <terrelln@fb.com>,
	"Austin S . Hemmelgarn" <ahferroin7@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	kernel-team@fb.com, Chris Mason <clm@fb.com>,
	Yann Collet <cyan@fb.com>, Adam Borowski <kilobyte@angband.pl>,
	David Sterba <dsterba@suse.cz>,
	squashfs-devel@lists.sourceforge.net,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] btrfs: Add zstd support
Date: Mon, 24 Jul 2017 03:28:29 +0800	[thread overview]
Message-ID: <201707240330.KEFoSeFW%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170720212743.3351201-4-terrelln@fb.com>

[-- Attachment #1: Type: text/plain, Size: 5583 bytes --]

Hi Nick,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.13-rc1 next-20170721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nick-Terrell/Add-xxhash-and-zstd-modules/20170723-092845
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=parisc 

All warnings (new ones prefixed by >>):

   lib/xxhash.c: In function 'xxh64':
>> lib/xxhash.c:236:1: warning: the frame size of 1688 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^
   lib/xxhash.c: In function 'xxh64_update':
   lib/xxhash.c:441:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^

vim +236 lib/xxhash.c

09c83807 Nick Terrell 2017-07-20  171  
09c83807 Nick Terrell 2017-07-20  172  uint64_t xxh64(const void *input, const size_t len, const uint64_t seed)
09c83807 Nick Terrell 2017-07-20  173  {
09c83807 Nick Terrell 2017-07-20  174  	const uint8_t *p = (const uint8_t *)input;
09c83807 Nick Terrell 2017-07-20  175  	const uint8_t *const b_end = p + len;
09c83807 Nick Terrell 2017-07-20  176  	uint64_t h64;
09c83807 Nick Terrell 2017-07-20  177  
09c83807 Nick Terrell 2017-07-20  178  	if (len >= 32) {
09c83807 Nick Terrell 2017-07-20  179  		const uint8_t *const limit = b_end - 32;
09c83807 Nick Terrell 2017-07-20  180  		uint64_t v1 = seed + PRIME64_1 + PRIME64_2;
09c83807 Nick Terrell 2017-07-20  181  		uint64_t v2 = seed + PRIME64_2;
09c83807 Nick Terrell 2017-07-20  182  		uint64_t v3 = seed + 0;
09c83807 Nick Terrell 2017-07-20  183  		uint64_t v4 = seed - PRIME64_1;
09c83807 Nick Terrell 2017-07-20  184  
09c83807 Nick Terrell 2017-07-20  185  		do {
09c83807 Nick Terrell 2017-07-20  186  			v1 = xxh64_round(v1, get_unaligned_le64(p));
09c83807 Nick Terrell 2017-07-20  187  			p += 8;
09c83807 Nick Terrell 2017-07-20  188  			v2 = xxh64_round(v2, get_unaligned_le64(p));
09c83807 Nick Terrell 2017-07-20  189  			p += 8;
09c83807 Nick Terrell 2017-07-20  190  			v3 = xxh64_round(v3, get_unaligned_le64(p));
09c83807 Nick Terrell 2017-07-20  191  			p += 8;
09c83807 Nick Terrell 2017-07-20  192  			v4 = xxh64_round(v4, get_unaligned_le64(p));
09c83807 Nick Terrell 2017-07-20  193  			p += 8;
09c83807 Nick Terrell 2017-07-20  194  		} while (p <= limit);
09c83807 Nick Terrell 2017-07-20  195  
09c83807 Nick Terrell 2017-07-20  196  		h64 = xxh_rotl64(v1, 1) + xxh_rotl64(v2, 7) +
09c83807 Nick Terrell 2017-07-20  197  			xxh_rotl64(v3, 12) + xxh_rotl64(v4, 18);
09c83807 Nick Terrell 2017-07-20  198  		h64 = xxh64_merge_round(h64, v1);
09c83807 Nick Terrell 2017-07-20  199  		h64 = xxh64_merge_round(h64, v2);
09c83807 Nick Terrell 2017-07-20  200  		h64 = xxh64_merge_round(h64, v3);
09c83807 Nick Terrell 2017-07-20  201  		h64 = xxh64_merge_round(h64, v4);
09c83807 Nick Terrell 2017-07-20  202  
09c83807 Nick Terrell 2017-07-20  203  	} else {
09c83807 Nick Terrell 2017-07-20  204  		h64  = seed + PRIME64_5;
09c83807 Nick Terrell 2017-07-20  205  	}
09c83807 Nick Terrell 2017-07-20  206  
09c83807 Nick Terrell 2017-07-20  207  	h64 += (uint64_t)len;
09c83807 Nick Terrell 2017-07-20  208  
09c83807 Nick Terrell 2017-07-20  209  	while (p + 8 <= b_end) {
09c83807 Nick Terrell 2017-07-20  210  		const uint64_t k1 = xxh64_round(0, get_unaligned_le64(p));
09c83807 Nick Terrell 2017-07-20  211  
09c83807 Nick Terrell 2017-07-20  212  		h64 ^= k1;
09c83807 Nick Terrell 2017-07-20  213  		h64 = xxh_rotl64(h64, 27) * PRIME64_1 + PRIME64_4;
09c83807 Nick Terrell 2017-07-20  214  		p += 8;
09c83807 Nick Terrell 2017-07-20  215  	}
09c83807 Nick Terrell 2017-07-20  216  
09c83807 Nick Terrell 2017-07-20  217  	if (p + 4 <= b_end) {
09c83807 Nick Terrell 2017-07-20  218  		h64 ^= (uint64_t)(get_unaligned_le32(p)) * PRIME64_1;
09c83807 Nick Terrell 2017-07-20  219  		h64 = xxh_rotl64(h64, 23) * PRIME64_2 + PRIME64_3;
09c83807 Nick Terrell 2017-07-20  220  		p += 4;
09c83807 Nick Terrell 2017-07-20  221  	}
09c83807 Nick Terrell 2017-07-20  222  
09c83807 Nick Terrell 2017-07-20  223  	while (p < b_end) {
09c83807 Nick Terrell 2017-07-20  224  		h64 ^= (*p) * PRIME64_5;
09c83807 Nick Terrell 2017-07-20  225  		h64 = xxh_rotl64(h64, 11) * PRIME64_1;
09c83807 Nick Terrell 2017-07-20  226  		p++;
09c83807 Nick Terrell 2017-07-20  227  	}
09c83807 Nick Terrell 2017-07-20  228  
09c83807 Nick Terrell 2017-07-20  229  	h64 ^= h64 >> 33;
09c83807 Nick Terrell 2017-07-20  230  	h64 *= PRIME64_2;
09c83807 Nick Terrell 2017-07-20  231  	h64 ^= h64 >> 29;
09c83807 Nick Terrell 2017-07-20  232  	h64 *= PRIME64_3;
09c83807 Nick Terrell 2017-07-20  233  	h64 ^= h64 >> 32;
09c83807 Nick Terrell 2017-07-20  234  
09c83807 Nick Terrell 2017-07-20  235  	return h64;
09c83807 Nick Terrell 2017-07-20 @236  }
09c83807 Nick Terrell 2017-07-20  237  EXPORT_SYMBOL(xxh64);
09c83807 Nick Terrell 2017-07-20  238  

:::::: The code at line 236 was first introduced by commit
:::::: 09c83807485b28f2b1813bcd3b7e2c7c3720234e lib: Add xxhash module

:::::: TO: Nick Terrell <terrelln@fb.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50926 bytes --]

  reply	other threads:[~2017-07-23 19:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 21:27 [PATCH v3 0/4] Add xxhash and zstd modules Nick Terrell
2017-07-20 21:27 ` [PATCH v3 1/4] lib: Add xxhash module Nick Terrell
2017-07-20 21:27 ` [PATCH v3 2/4] lib: Add zstd modules Nick Terrell
2017-07-20 21:27 ` [PATCH v3 3/4] btrfs: Add zstd support Nick Terrell
2017-07-23 19:28   ` kbuild test robot [this message]
2017-07-24 17:25   ` kbuild test robot
2017-07-25 23:19   ` Giovanni Cabiddu
2017-08-18 15:37     ` David Sterba
2017-07-20 21:27 ` [PATCH v3 4/4] squashfs: " Nick Terrell
2017-07-31  1:50   ` Phillip Lougher
2017-07-31  2:18     ` Phillip Lougher
2017-07-31 21:30     ` Nick Terrell
2017-07-21 11:16 ` [PATCH v3 0/4] Add xxhash and zstd modules Austin S. Hemmelgarn
2017-07-21 11:18   ` Austin S. Hemmelgarn
2017-07-21 15:56 ` Austin S. Hemmelgarn
2017-07-22 11:35   ` Adam Borowski
2017-07-24 13:44     ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201707240330.KEFoSeFW%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=ahferroin7@gmail.com \
    --cc=clm@fb.com \
    --cc=cyan@fb.com \
    --cc=dsterba@suse.cz \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@01.org \
    --cc=kernel-team@fb.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®