mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Nick Terrell <terrelln@fb.com>
Cc: "Austin S . Hemmelgarn" <ahferroin7@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"kernel-team@fb.com" <kernel-team@fb.com>,
	Chris Mason <clm@fb.com>, Yann Collet <cyan@fb.com>,
	Adam Borowski <kilobyte@angband.pl>,
	David Sterba <dsterba@suse.cz>,
	"squashfs-devel@lists.sourceforge.net" 
	<squashfs-devel@lists.sourceforge.net>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Weigang Li <weigang.li@intel.com>,
	Brian Will <brian.will@intel.com>,
	Brian A Keating <brian.a.keating@intel.com>,
	Giovanni Cabiddu <giovanni.cabiddu@gmail.com>
Subject: Re: [PATCH v3 3/4] btrfs: Add zstd support
Date: Wed, 26 Jul 2017 00:19:29 +0100	[thread overview]
Message-ID: <20170725231929.GA28789@silv-upstream1.ir.intel.com> (raw)
In-Reply-To: <20170720212743.3351201-4-terrelln@fb.com>

Hi Nick,

On Thu, Jul 20, 2017 at 10:27:42PM +0100, Nick Terrell wrote:
> Add zstd compression and decompression support to BtrFS. zstd at its
> fastest level compresses almost as well as zlib, while offering much
> faster compression and decompression, approaching lzo speeds.
Can we look at integrating the zstd implementation below the acomp API
available in the crypto subsystem?
(https://github.com/torvalds/linux/blob/master/crypto/acompress.c)
Acomp was designed to provide a generic and uniform API for compression
in the kernel which hides algorithm specific details to frameworks.
In future it would be nice to see btrfs using exclusively acomp
for compression. This way when a new compression algorithm is exposed
through acomp, it will be available immediately in btrfs.
Furthermore, any framework in the kernel that will use acomp will be
automatically enabled to use zstd.
What do you think?

Here is a prototype that shows how btrfs can be integrated with
acomp: https://patchwork.kernel.org/patch/9201741/

Regards,

-- 
Giovanni

  parent reply	other threads:[~2017-07-25 23:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 21:27 [PATCH v3 0/4] Add xxhash and zstd modules Nick Terrell
2017-07-20 21:27 ` [PATCH v3 1/4] lib: Add xxhash module Nick Terrell
2017-07-20 21:27 ` [PATCH v3 2/4] lib: Add zstd modules Nick Terrell
2017-07-20 21:27 ` [PATCH v3 3/4] btrfs: Add zstd support Nick Terrell
2017-07-23 19:28   ` kbuild test robot
2017-07-24 17:25   ` kbuild test robot
2017-07-25 23:19   ` Giovanni Cabiddu [this message]
2017-08-18 15:37     ` David Sterba
2017-07-20 21:27 ` [PATCH v3 4/4] squashfs: " Nick Terrell
2017-07-31  1:50   ` Phillip Lougher
2017-07-31  2:18     ` Phillip Lougher
2017-07-31 21:30     ` Nick Terrell
2017-07-21 11:16 ` [PATCH v3 0/4] Add xxhash and zstd modules Austin S. Hemmelgarn
2017-07-21 11:18   ` Austin S. Hemmelgarn
2017-07-21 15:56 ` Austin S. Hemmelgarn
2017-07-22 11:35   ` Adam Borowski
2017-07-24 13:44     ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725231929.GA28789@silv-upstream1.ir.intel.com \
    --to=giovanni.cabiddu@intel.com \
    --cc=ahferroin7@gmail.com \
    --cc=brian.a.keating@intel.com \
    --cc=brian.will@intel.com \
    --cc=clm@fb.com \
    --cc=cyan@fb.com \
    --cc=dsterba@suse.cz \
    --cc=giovanni.cabiddu@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-team@fb.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=terrelln@fb.com \
    --cc=weigang.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome