* [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text
@ 2017-07-24 6:45 Martin Kepplinger
2017-07-24 7:41 ` Hans de Goede
2017-07-24 8:10 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Martin Kepplinger @ 2017-07-24 6:45 UTC (permalink / raw)
To: gregkh, hdegoede, michael.thayer; +Cc: devel, linux-kernel, Martin Kepplinger
This fixes typos in vboxvideo's help text.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
drivers/staging/vboxvideo/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..2b058d573cf1 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -6,7 +6,7 @@ config DRM_VBOXVIDEO
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
- Although it is possible to builtin this module, it is advised
+ Although it is possible to build in this module, it is advised
to build this driver as a module, so that it can be updated
- independently of the kernel. Select M to built this driver as a
+ independently of the kernel. Select M to build this driver as a
module and add support for these devices via drm/kms interfaces.
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text
2017-07-24 6:45 [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text Martin Kepplinger
@ 2017-07-24 7:41 ` Hans de Goede
2017-07-24 8:10 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2017-07-24 7:41 UTC (permalink / raw)
To: Martin Kepplinger, gregkh, michael.thayer; +Cc: devel, linux-kernel
Hi,
On 24-07-17 08:45, Martin Kepplinger wrote:
> This fixes typos in vboxvideo's help text.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/vboxvideo/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
> index a52746f9a670..2b058d573cf1 100644
> --- a/drivers/staging/vboxvideo/Kconfig
> +++ b/drivers/staging/vboxvideo/Kconfig
> @@ -6,7 +6,7 @@ config DRM_VBOXVIDEO
> This is a KMS driver for the virtual Graphics Card used in
> Virtual Box virtual machines.
>
> - Although it is possible to builtin this module, it is advised
> + Although it is possible to build in this module, it is advised
> to build this driver as a module, so that it can be updated
> - independently of the kernel. Select M to built this driver as a
> + independently of the kernel. Select M to build this driver as a
> module and add support for these devices via drm/kms interfaces.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text
2017-07-24 6:45 [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text Martin Kepplinger
2017-07-24 7:41 ` Hans de Goede
@ 2017-07-24 8:10 ` Dan Carpenter
2017-07-24 8:26 ` [PATCH v2] " Martin Kepplinger
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2017-07-24 8:10 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: gregkh, hdegoede, michael.thayer, devel, linux-kernel
On Mon, Jul 24, 2017 at 08:45:16AM +0200, Martin Kepplinger wrote:
> This fixes typos in vboxvideo's help text.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/staging/vboxvideo/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
> index a52746f9a670..2b058d573cf1 100644
> --- a/drivers/staging/vboxvideo/Kconfig
> +++ b/drivers/staging/vboxvideo/Kconfig
> @@ -6,7 +6,7 @@ config DRM_VBOXVIDEO
> This is a KMS driver for the virtual Graphics Card used in
> Virtual Box virtual machines.
>
> - Although it is possible to builtin this module, it is advised
> + Although it is possible to build in this module, it is advised
I feel like this is unclear. Perhaps say something like:
Although it is possible to build this driver built-in to the
kernel, it is advised ...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] staging: vboxvideo: Kconfig: Fix typos in help text
2017-07-24 8:10 ` Dan Carpenter
@ 2017-07-24 8:26 ` Martin Kepplinger
2017-07-24 8:30 ` [PATCH v3] " Martin Kepplinger
0 siblings, 1 reply; 6+ messages in thread
From: Martin Kepplinger @ 2017-07-24 8:26 UTC (permalink / raw)
To: dan.carpenter
Cc: gregkh, hdegoede, michael.thayer, devel, linux-kernel, Martin Kepplinger
This fixes typos in vboxvideo's help text. Most notably, "to builtin
this module" becomes "to build this driver built-in to the kernel".
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
Thanks Dan. I actually also had the feeling that even though it's better,
it's not as clear as it could be. It's either a module or built-in; not both.
revision history
----------------
v2: Say "to build this driver built-in to the kernel" instead of "build in
this module".
drivers/staging/vboxvideo/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..b8df8f60823a 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -6,7 +6,8 @@ config DRM_VBOXVIDEO
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
- Although it is possible to builtin this module, it is advised
- to build this driver as a module, so that it can be updated
- independently of the kernel. Select M to built this driver as a
- module and add support for these devices via drm/kms interfaces.
+ Although it is possible to build this driver built-in to the
+ kernel, it is advised to build this driver as a module, so that
+ it can be updated independently of the kernel. Select M to build
+ this driver as a module and add support for these devices via
+ drm/kms interfaces.
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3] staging: vboxvideo: Kconfig: Fix typos in help text
2017-07-24 8:26 ` [PATCH v2] " Martin Kepplinger
@ 2017-07-24 8:30 ` Martin Kepplinger
2017-07-24 8:32 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Martin Kepplinger @ 2017-07-24 8:30 UTC (permalink / raw)
To: dan.carpenter
Cc: gregkh, hdegoede, michael.thayer, devel, linux-kernel, Martin Kepplinger
This fixes typos in vboxvideo's help text. Most notably, "to builtin
this module" becomes "to build this driver built-in to the kernel".
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
revision history
----------------
v3: Avoid a repetition of "this driver".
v2: Say "to build this driver built-in to the kernel" instead of "build in
this module". - Thanks Dan.
drivers/staging/vboxvideo/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig
index a52746f9a670..3200b6895178 100644
--- a/drivers/staging/vboxvideo/Kconfig
+++ b/drivers/staging/vboxvideo/Kconfig
@@ -6,7 +6,8 @@ config DRM_VBOXVIDEO
This is a KMS driver for the virtual Graphics Card used in
Virtual Box virtual machines.
- Although it is possible to builtin this module, it is advised
- to build this driver as a module, so that it can be updated
- independently of the kernel. Select M to built this driver as a
- module and add support for these devices via drm/kms interfaces.
+ Although it is possible to build this driver built-in to the
+ kernel, it is advised to build it as a module, so that it can
+ be updated independently of the kernel. Select M to build this
+ driver as a module and add support for these devices via drm/kms
+ interfaces.
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-24 8:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-24 6:45 [PATCH] staging: vboxvideo: Kconfig: Fix typos in help text Martin Kepplinger
2017-07-24 7:41 ` Hans de Goede
2017-07-24 8:10 ` Dan Carpenter
2017-07-24 8:26 ` [PATCH v2] " Martin Kepplinger
2017-07-24 8:30 ` [PATCH v3] " Martin Kepplinger
2017-07-24 8:32 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®