mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: cpcap-charger:  add OMAP_USB2 dependency
Date: Mon, 24 Jul 2017 20:51:16 +0200	[thread overview]
Message-ID: <20170724185116.6dnjyelzf4l37fmk@earth> (raw)
In-Reply-To: <20170721161511.3334292-1-arnd@arndb.de>

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

Hi,

On Fri, Jul 21, 2017 at 06:14:37PM +0200, Arnd Bergmann wrote:
> When CONFIG_OMAP_USB2 is set to 'm' and the charger driver is built-in,
> we get this link failure:
> 
> drivers/power/supply/cpcap-charger.o: In function `cpcap_charger_probe':
> cpcap-charger.c:(.text+0x48c): undefined reference to `omap_usb2_set_comparator'
> drivers/power/supply/cpcap-charger.o: In function `cpcap_charger_remove':
> cpcap-charger.c:(.text+0x774): undefined reference to `omap_usb2_set_comparator'
> 
> This adds a dependency to prevent that problem, while still allowing
> compile-testing with the OMAP_USB2 driver completely disabled.
> 
> Fixes: 0c9888e3c192 ("power: supply: cpcap-charger: Add minimal CPCAP PMIC battery charger")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks, applied to power-supply's fixes branch.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-07-24 18:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 16:14 Arnd Bergmann
2017-07-24 18:51 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724185116.6dnjyelzf4l37fmk@earth \
    --to=sre@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®