From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ingo Molnar <mingo@kernel.org>,
Francis Deslauriers <francis.deslauriers@efficios.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] [BUGFIX] kprobes/x86: Do not jump-optimize kprobes on irq entry code
Date: Tue, 25 Jul 2017 10:45:54 +0900 [thread overview]
Message-ID: <20170725104554.b58850228986eb94d56dcb0e@kernel.org> (raw)
In-Reply-To: <20170725091529.f278542cb1216ae453709371@kernel.org>
On Tue, 25 Jul 2017 09:15:29 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > arch/x86/kernel/unwind_frame.c is only compiled when CONFIG_FRAME_POINTER
> > is enabled, but CONFIG_KPROBES does not depend on it.
> >
> > Is unwind_frame.c really where in_entry_code() should be implemented, now
> > that its symbol becomes exposed to other compile units ?
>
> At least kprobes needs it. (as far
> It seems we can move it in arch/x86/entry/common.c or
> somewhere in header. (arm has arch/arm/include/asm/traps.h for
> that purpose)
As far as I can see, that code is only for unwinder or kprobes,
and only arm/arm64 has similar code.
I've decided to make this fix kprobe/opt.c local, since this fix
is also needed for stable. I'll send v2 patch soon.
Thanks,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-07-25 1:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 13:50 Masami Hiramatsu
2017-07-24 14:28 ` Mathieu Desnoyers
2017-07-25 0:15 ` Masami Hiramatsu
2017-07-25 1:45 ` Masami Hiramatsu [this message]
2017-07-25 4:29 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725104554.b58850228986eb94d56dcb0e@kernel.org \
--to=mhiramat@kernel.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=francis.deslauriers@efficios.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®