[PATCH] device property: export irqchip_fwnode_ops

[PATCH] device property: export irqchip_fwnode_ops

[Arnd Bergmann]

The newly added irqchip_fwnode_ops structure is not exported, which can
lead to link errors:

ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined!

I checked that all other such symbols that were introduced are
exported if they need to be, this is the only missing one.

Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/irq/irqdomain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index e064fd1390f1..9e8a075117a3 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -42,6 +42,7 @@ static inline void debugfs_remove_domain_dir(struct irq_domain *d) { }
 #endif
 
 const struct fwnode_operations irqchip_fwnode_ops;
+EXPORT_SYMBOL_GPL(irqchip_fwnode_ops);
 
 /**
  * irq_domain_alloc_fwnode - Allocate a fwnode_handle suitable for
-- 
2.9.0

Re: [PATCH] device property: export irqchip_fwnode_ops

[Rafael J. Wysocki]

On Tuesday, July 25, 2017 05:32:31 PM Arnd Bergmann wrote:
> The newly added irqchip_fwnode_ops structure is not exported, which can
> lead to link errors:
> 
> ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined!
> 
> I checked that all other such symbols that were introduced are
> exported if they need to be, this is the only missing one.
> 
> Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for the fix.

It is linux-next only at this point, isn't it?

Re: [PATCH] device property: export irqchip_fwnode_ops

[Arnd Bergmann]

On Wed, Jul 26, 2017 at 2:13 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, July 25, 2017 05:32:31 PM Arnd Bergmann wrote:
>> The newly added irqchip_fwnode_ops structure is not exported, which can
>> lead to link errors:
>>
>> ERROR: "irqchip_fwnode_ops" [drivers/gpio/gpio-xgene-sb.ko] undefined!
>>
>> I checked that all other such symbols that were introduced are
>> exported if they need to be, this is the only missing one.
>>
>> Fixes: db3e50f3234b ("device property: Get rid of struct fwnode_handle type field")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for the fix.
>
> It is linux-next only at this point, isn't it?

Correct, this is how I decided to send it to you rather than the
irqchip maintainers:

$ git log --oneline --ancestry-path --merges
db3e50f3234b..next/master | tail -n 5
cd8d05edc1ca Merge remote-tracking branch 'idle/next'
db7be21c3bad Merge remote-tracking branch 'pm/linux-next'
e2e9e06e4bb2 Merge branch 'acpi-numa' into linux-next
ed1d633e4584 Merge branches 'pm-tools' and 'pm-sleep' into linux-next
796cbe7125c1 Merge branch 'device-properties' into linux-next

      Arnd