From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: make orc_types.h headers match
Date: Tue, 25 Jul 2017 10:49:03 -0500 [thread overview]
Message-ID: <20170725154903.22lf6srssd6n36lk@treble> (raw)
In-Reply-To: <20170725152858.21264-1-arnd@arndb.de>
On Tue, Jul 25, 2017 at 05:28:48PM +0200, Arnd Bergmann wrote:
> Building objtool causes a warning on the latest linux-next kernels:
>
> warning: objtool: orc_types.h differs from kernel
>
> From what I can tell, we have two slightly different copies of the same
> header, and we try to ensure they are the same with the warning.
Oops!
> This picks the copy from the x86 headers (without the __packed
> annotation), by roll of dice.
You lost ;-) It should be __packed.
BTW this will also be fixed when the ORC unwinder gets merged, which
will presumably be soon.
> Fixes: 39358a033b2e ("objtool, x86: Add facility for asm code to provide unwind hints")
^^^ This is the one that introduced the bug.
--
Josh
prev parent reply other threads:[~2017-07-25 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:28 Arnd Bergmann
2017-07-25 15:49 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725154903.22lf6srssd6n36lk@treble \
--to=jpoimboe@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®