* [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata
@ 2017-07-27 3:19 Amitoj Kaur Chawla
2017-07-27 5:09 ` [greybus-dev] " Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2017-07-27 3:19 UTC (permalink / raw)
To: hvaibhav.linux, johan, elder, gregkh, greybus-dev, devel, linux-kernel
Unnecessary platform_set_drvdata() has been removed since the driver
core clears the driver data to NULL after device release or on
probe failure. There is no need to manually clear the device
driver data to NULL.
The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@@
struct platform_device *pdev;
@@
- platform_set_drvdata(pdev, NULL);
//</smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/staging/greybus/arche-platform.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index eced2d2..358b260 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -607,7 +607,6 @@ static int arche_platform_remove(struct platform_device *pdev)
device_remove_file(&pdev->dev, &dev_attr_state);
device_for_each_child(&pdev->dev, NULL, arche_remove_child);
arche_platform_poweroff_seq(arche_pdata);
- platform_set_drvdata(pdev, NULL);
if (usb3613_hub_mode_ctrl(false))
dev_warn(arche_pdata->dev, "failed to control hub device\n");
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [greybus-dev] [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata
2017-07-27 3:19 [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata Amitoj Kaur Chawla
@ 2017-07-27 5:09 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2017-07-27 5:09 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: hvaibhav.linux, johan, elder, gregkh, greybus-dev, devel, linux-kernel
On 26-07-17, 23:19, Amitoj Kaur Chawla wrote:
> Unnecessary platform_set_drvdata() has been removed since the driver
> core clears the driver data to NULL after device release or on
> probe failure. There is no need to manually clear the device
> driver data to NULL.
>
> The Coccinelle semantic patch used to make this change is as follows:
> //<smpl>
> @@
> struct platform_device *pdev;
> @@
> - platform_set_drvdata(pdev, NULL);
> //</smpl>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/staging/greybus/arche-platform.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index eced2d2..358b260 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -607,7 +607,6 @@ static int arche_platform_remove(struct platform_device *pdev)
> device_remove_file(&pdev->dev, &dev_attr_state);
> device_for_each_child(&pdev->dev, NULL, arche_remove_child);
> arche_platform_poweroff_seq(arche_pdata);
> - platform_set_drvdata(pdev, NULL);
>
> if (usb3613_hub_mode_ctrl(false))
> dev_warn(arche_pdata->dev, "failed to control hub device\n");
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-27 5:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-27 3:19 [PATCH] staging: greybus: Remove unnecessary platform_set_drvdata Amitoj Kaur Chawla
2017-07-27 5:09 ` [greybus-dev] " Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®