mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] staging:wlan-ng Correct multiple line dereference
@ 2017-07-28 10:44 janani-sankarababu
  2017-07-28 11:01 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: janani-sankarababu @ 2017-07-28 10:44 UTC (permalink / raw)
  To: gregkh
  Cc: sergio.paracuellos, davem, adrien.descamps, devel, linux-kernel,
	janani-sankarababu

This patch fixes the multiple line dereference Warning reported by
checkpath script. This has been made to simplify the code and make
it more readable.

Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2fc5f3e 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
 		kfree(ctlx);
 	} else if (mode == DOWAIT) {
 		struct usbctlx_cmd_completor completor;
+		struct usbctlx_completor *cmplt;
+
+		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+					   &cmd->result);

-		result =
-		    hfa384x_usbctlx_complete_sync(hw, ctlx,
-						  init_cmd_completor(&completor,
-								     &ctlx->
-								     inbuf.
-								     cmdresp,
-								     &cmd->
-								     result));
+		result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
 	}

done:
--
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging:wlan-ng Correct multiple line dereference
  2017-07-28 10:44 [PATCH v2] staging:wlan-ng Correct multiple line dereference janani-sankarababu
@ 2017-07-28 11:01 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-07-28 11:01 UTC (permalink / raw)
  To: janani-sankarababu
  Cc: gregkh, devel, linux-kernel, adrien.descamps, sergio.paracuellos, davem

>From header.  Subject.  Doesn't apply (read
Documentation/process/email-clients.rst).


On Fri, Jul 28, 2017 at 04:14:29PM +0530, janani-sankarababu wrote:
> This patch fixes the multiple line dereference Warning reported by
> checkpath script. This has been made to simplify the code and make
> it more readable.
> 
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---

Put a changelog under the --- cut off:
v3:  patch format issues

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-28 11:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-28 10:44 [PATCH v2] staging:wlan-ng Correct multiple line dereference janani-sankarababu
2017-07-28 11:01 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®