From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcus Wolf <marcus.wolf@wolf-entwicklungen.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: use div_u64 for 64-bit division
Date: Fri, 28 Jul 2017 17:26:36 +0300 [thread overview]
Message-ID: <20170728142636.e6vzzwhc53mv6qpt@mwanda> (raw)
In-Reply-To: <569585967.8859.1501251665326@ox.hosteurope.de>
On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote:
> Hi Arnd,
>
> we already have a patch for this:
> [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation
> from 20.07.2017
https://patchwork.kernel.org/patch/9855261/
>
> Maybe I did something wrong, but my first solution was exactly like your
> proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I
> made a little bit more complicated fix. If I did something wrong and yours is
> fine, we should go for yours, because it is a shorter solution.
>
Your patch doesn't apply for one thing.... :( Read
Documentation/process/email-clients.rst It probably would have been Ok
otherwise.
I'm pretty sure that Arnd's patch is going to be fine.
regards,
dan carpenter
next prev parent reply other threads:[~2017-07-28 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:23 Arnd Bergmann
2017-07-28 14:21 ` Marcus Wolf
2017-07-28 14:26 ` Dan Carpenter [this message]
2017-07-28 14:50 ` Marcus Wolf
2017-07-28 15:16 ` Send a large patch right now or is it better to do it later? Marcus Wolf
2017-07-29 7:23 ` Dan Carpenter
2017-08-28 15:17 ` Greg Kroah-Hartman
2017-07-28 14:26 ` [PATCH] staging: pi433: use div_u64 for 64-bit division Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728142636.e6vzzwhc53mv6qpt@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.wolf@wolf-entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®