From: Marcus Wolf <marcus.wolf@wolf-entwicklungen.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Send a large patch right now or is it better to do it later?
Date: Fri, 28 Jul 2017 17:16:56 +0200 (CEST) [thread overview]
Message-ID: <643844683.9182.1501255016794@ox.hosteurope.de> (raw)
In-Reply-To: <20170728142636.e6vzzwhc53mv6qpt@mwanda>
Hi Greg,
according to the proposals of Walter Harms, I revised the rf69.c: I replaced
some macros with inline functions and removed some obsolete ifdefs. According to
walter this will improve the resource situation. In addition the readybility is
enhanced, since lines got shorter. It's a quite big change, that touched nearly
every function in that file.
I was testing the new code for a while now and did not observer a problem so
far. But I don't have a kind of unit test, so my tests for sure didn't cover
everything.
Is it a good time, to submit such a change in these days, or is it prefrable to
submit it later?
In adition, I am a bit afraid of my current mailtool doing something
unexpected...
If you like, I can give it a try!
Cheers,
Marcus
P.S. Can you process diffs fom SVN, too, or is it mandatory to create the diff
with git?
next prev parent reply other threads:[~2017-07-28 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:23 [PATCH] staging: pi433: use div_u64 for 64-bit division Arnd Bergmann
2017-07-28 14:21 ` Marcus Wolf
2017-07-28 14:26 ` Dan Carpenter
2017-07-28 14:50 ` Marcus Wolf
2017-07-28 15:16 ` Marcus Wolf [this message]
2017-07-29 7:23 ` Send a large patch right now or is it better to do it later? Dan Carpenter
2017-08-28 15:17 ` Greg Kroah-Hartman
2017-07-28 14:26 ` [PATCH] staging: pi433: use div_u64 for 64-bit division Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643844683.9182.1501255016794@ox.hosteurope.de \
--to=marcus.wolf@wolf-entwicklungen.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®