From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devel@driverdev.osuosl.org,
Michael Thayer <michael.thayer@oracle.com>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR
Date: Fri, 28 Jul 2017 17:06:02 -0700 [thread overview]
Message-ID: <20170729000602.GA5026@kroah.com> (raw)
In-Reply-To: <20170728132118.261004-1-arnd@arndb.de>
On Fri, Jul 28, 2017 at 03:21:01PM +0200, Arnd Bergmann wrote:
> vboxvideo fails to link without genalloc:
>
> drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
> vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc'
> drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free':
> vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'
>
> This adds a Kconfig select statement, mirroring what all the other
> users have.
>
> Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/vboxvideo/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Hans sent this same patch 2 days ago, sorry, just applied it now.
greg k-h
prev parent reply other threads:[~2017-07-29 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:21 Arnd Bergmann
2017-07-29 0:06 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170729000602.GA5026@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome