mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Kees Cook <keescook@chromium.org>
Cc: Manfred Spraul <manfred@colorfullife.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: lsipc(1) triggers general protection fault in sysvipc_shm_proc_show() on v4.13-rc2+
Date: Sun, 30 Jul 2017 23:06:38 +0200	[thread overview]
Message-ID: <20170730210638.GA1737@light.dominikbrodowski.net> (raw)
In-Reply-To: <CAGXu5j+BoPVscCeMRxq6fyVdOVsnVmJvTHqgkW0x5C8D=32VRA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Sun, Jul 30, 2017 at 01:36:51PM -0700, Kees Cook wrote:
> On Sun, Jul 30, 2017 at 1:16 PM, Dominik Brodowski
> <linux@dominikbrodowski.net> wrote:
> > I've bisected it to between v4.13-rc1 and 96080f697786 so far, ~7 more
> > kernels/reboots to go. That leaves no code changes to ipc/, but some
> > randstruct changes ( I have set CONFIG_GCC_PLUGIN_RANDSTRUCT=y ) which
> > touch some ipc-related code.
> 
> Excellent, thanks; I bisected this as well. There was a missing
> container_of() in the proc handler. I've sent a patch for this now.
> Thanks for the report!

Thank you for fixing this issue - I can confirm that your patch (v2), on top
of v4.13-rc3, fixes the issue I've been seeing.

Thanks again,
	Dominik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-07-30 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30 10:10 Dominik Brodowski
2017-07-30 16:28 ` Kees Cook
2017-07-30 17:47   ` Kees Cook
2017-07-30 20:16     ` Dominik Brodowski
2017-07-30 20:36       ` Kees Cook
2017-07-30 21:06         ` Dominik Brodowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170730210638.GA1737@light.dominikbrodowski.net \
    --to=linux@dominikbrodowski.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®