* [PATCH] ACPI / dock: constify attribute_group structure
@ 2017-08-02 0:28 Amitoj Kaur Chawla
2017-08-09 22:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2017-08-02 0:28 UTC (permalink / raw)
To: rjw, lenb, linux-acpi, linux-kernel
Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
7902 3528 64 11494 2ce6 drivers/acpi/dock.o
File size after:
text data bss dec hex filename
7998 3432 64 11494 2ce6 drivers/acpi/dock.o
This change was made with the help of Coccinelle.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/acpi/dock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 0c00208..2305e1a 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -585,7 +585,7 @@ static struct attribute *dock_attributes[] = {
NULL
};
-static struct attribute_group dock_attribute_group = {
+static const struct attribute_group dock_attribute_group = {
.attrs = dock_attributes
};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI / dock: constify attribute_group structure
2017-08-02 0:28 [PATCH] ACPI / dock: constify attribute_group structure Amitoj Kaur Chawla
@ 2017-08-09 22:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2017-08-09 22:44 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: lenb, linux-acpi, linux-kernel
On Wednesday, August 2, 2017 2:28:46 AM CEST Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 7902 3528 64 11494 2ce6 drivers/acpi/dock.o
>
> File size after:
> text data bss dec hex filename
> 7998 3432 64 11494 2ce6 drivers/acpi/dock.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/acpi/dock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index 0c00208..2305e1a 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -585,7 +585,7 @@ static struct attribute *dock_attributes[] = {
> NULL
> };
>
> -static struct attribute_group dock_attribute_group = {
> +static const struct attribute_group dock_attribute_group = {
> .attrs = dock_attributes
> };
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-09 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02 0:28 [PATCH] ACPI / dock: constify attribute_group structure Amitoj Kaur Chawla
2017-08-09 22:44 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®