From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wolf Entwicklungen <Marcus.Wolf@Wolf-Entwicklungen.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcus Wolf <linux@Wolf-Entwicklungen.de>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions
Date: Wed, 2 Aug 2017 14:56:22 +0300 [thread overview]
Message-ID: <20170802115622.56ayoh6ogrv347d6@mwanda> (raw)
In-Reply-To: <20170802115330.uvvzqrimbz2ixoyk@mwanda>
On Wed, Aug 02, 2017 at 02:53:30PM +0300, Dan Carpenter wrote:
> > +{
> > + u8 tempVal;
>
Btw, just call this "u8 tmp;". The word "temp" is short for temperature
and "val" doesn't add any information because it's clearly a value.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-02 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:10 Wolf Entwicklungen
2017-08-02 11:14 ` Wolf Entwicklungen
2017-08-02 11:53 ` Dan Carpenter
2017-08-02 11:56 ` Dan Carpenter [this message]
2017-08-02 12:07 ` Marcus Wolf
2017-08-02 12:14 ` Dan Carpenter
2017-08-02 11:34 Wolf Entwicklungen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802115622.56ayoh6ogrv347d6@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Marcus.Wolf@Wolf-Entwicklungen.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®