From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcus Wolf <marcus.wolf@wolf-entwicklungen.de>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions
Date: Wed, 2 Aug 2017 15:14:26 +0300 [thread overview]
Message-ID: <20170802121426.l3wmnyeeoig3p44u@mwanda> (raw)
In-Reply-To: <1105187501.38159.1501675658122@ox.hosteurope.de>
On Wed, Aug 02, 2017 at 02:07:37PM +0200, Marcus Wolf wrote:
> Hi Dan,
>
> I get your point and I understand, that there need to be rules to
> simplify the life for the maintainers...
>
> But I honestly must confess, that at the moment, I don't have the
> time for doing that. I am into two customer projects, that keep me
> very busy these weeks.
>
> The only thing, I can offer, is to remove all the lines, dealing
> with the #ifdef DEBUG and leave the rest, as it is and send it again.
> Then all other changes are related to the move from macro to inline...
> If that helps, please let me know.
>
> If it needs further fragmentation, it'll take something like half
> a day / a day. I most probably can spent that day end of August,
> begin of September the earliest.
>
One trick that might help is you can just use `git citool` and highlight
all the rmw() lines, add selected lines to the commit, then commit that
as one patch. Repeat for all five patches.
The kernel process does kind of have a steep learning with redoing
patches... Sorry about that.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-02 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:10 Wolf Entwicklungen
2017-08-02 11:14 ` Wolf Entwicklungen
2017-08-02 11:53 ` Dan Carpenter
2017-08-02 11:56 ` Dan Carpenter
2017-08-02 12:07 ` Marcus Wolf
2017-08-02 12:14 ` Dan Carpenter [this message]
2017-08-02 11:34 Wolf Entwicklungen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802121426.l3wmnyeeoig3p44u@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.wolf@wolf-entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®