From: David Miller <davem@davemloft.net>
To: tsbogend@alpha.franken.de
Cc: isubramanian@apm.com, kchudgar@apm.com, qnguyen@apm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
labbott@redhat.com
Subject: Re: [PATCH net] xgene: Always get clk source, but ignore if it's missing for SGMII ports
Date: Fri, 04 Aug 2017 11:30:54 -0700 (PDT) [thread overview]
Message-ID: <20170804.113054.760644132949601023.davem@davemloft.net> (raw)
In-Reply-To: <20170803140311.34C7E50870B@solo.franken.de>
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Thu, 3 Aug 2017 15:43:14 +0200
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> Even the driver doesn't do anything with the clk source for SGMII
> ports it needs to be enabled by doing a devm_clk_get(), if there is
> a clk source in DT.
>
> Fixes: 0db01097cabd ('xgene: Don't fail probe, if there is no clk resource for SGMII interfaces')
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Tested-by: Laura Abbott <labbott@redhat.com>
> Acked-by: Iyappan Subramanian <isubramanian@apm.com>
Applied, thanks.
prev parent reply other threads:[~2017-08-04 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 13:43 Thomas Bogendoerfer
2017-08-04 11:00 ` Will Deacon
2017-08-04 18:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804.113054.760644132949601023.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qnguyen@apm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®