mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: James Smart <jsmart2021@gmail.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return
Date: Mon, 14 Aug 2017 10:19:24 -0400	[thread overview]
Message-ID: <20170814141924.sabddysk2bdg6vek@codemonkey.org.uk> (raw)
In-Reply-To: <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org>

On Fri, Aug 11, 2017 at 07:44:19PM +0000, Linux Kernel wrote:
 > Web:        https://git.kernel.org/torvalds/c/0fb228d30b8d72bfee51f57e638d412324d44a11
 > Commit:     0fb228d30b8d72bfee51f57e638d412324d44a11
 > Parent:     758f3735580c21b8a36d644128af6608120a1dde
 > Refname:    refs/heads/master
 > Author:     James Smart <jsmart2021@gmail.com>
 > AuthorDate: Tue Aug 1 15:12:39 2017 -0700
 > Committer:  Christoph Hellwig <hch@lst.de>
 > CommitDate: Thu Aug 10 11:06:38 2017 +0200
 > 
 >     nvmet_fc: add defer_req callback for deferment of cmd buffer return


 > +
 > +	/* Cleanup defer'ed IOs in queue */
 > +	list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
 > +		list_del(&deferfcp->req_list);
 > +		kfree(deferfcp);
 > +	}

Shouldn't this be list_for_each_entry_safe ?

	Dave

       reply	other threads:[~2017-08-14 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org>
2017-08-14 14:19 ` Dave Jones [this message]
2017-08-14 16:38   ` Christoph Hellwig
2017-08-14 17:57     ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814141924.sabddysk2bdg6vek@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=hch@lst.de \
    --cc=jsmart2021@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome