From: James Smart <jsmart2021@gmail.com>
To: Christoph Hellwig <hch@lst.de>,
Dave Jones <davej@codemonkey.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return
Date: Mon, 14 Aug 2017 10:57:32 -0700 [thread overview]
Message-ID: <9ec45c45-0a9d-1bb5-8a10-ed9ab5e072db@gmail.com> (raw)
In-Reply-To: <20170814163829.GA27442@lst.de>
On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
> On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>> > +
>> > + /* Cleanup defer'ed IOs in queue */
>> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>> > + list_del(&deferfcp->req_list);
>> > + kfree(deferfcp);
>> > + }
>>
>> Shouldn't this be list_for_each_entry_safe ?
>
> It should. James, can you send a fixup?
>
yes - I was had already identified this fix and in the process of
putting it out.
-- james
prev parent reply other threads:[~2017-08-14 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org>
2017-08-14 14:19 ` Dave Jones
2017-08-14 16:38 ` Christoph Hellwig
2017-08-14 17:57 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec45c45-0a9d-1bb5-8a10-ed9ab5e072db@gmail.com \
--to=jsmart2021@gmail.com \
--cc=davej@codemonkey.org.uk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome