From: Guenter Roeck <linux@roeck-us.net>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed
Date: Mon, 14 Aug 2017 07:47:50 -0700 [thread overview]
Message-ID: <20170814144750.GC14491@roeck-us.net> (raw)
In-Reply-To: <32d58c86a3afbdfc25fe26a9e51df917ce5da4ac.1501832354.git.michal.simek@xilinx.com>
On Fri, Aug 04, 2017 at 09:39:17AM +0200, Michal Simek wrote:
> Showing message that driver is loaded is common across drivers.
> This change also fixes checkpatch (--strict) warning
> "Alignment should match open parenthesis".
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> drivers/watchdog/cadence_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index dadd3b0c2d49..064cf7b6c1c5 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -368,7 +368,7 @@ static int cdns_wdt_probe(struct platform_device *pdev)
> }
> platform_set_drvdata(pdev, wdt);
>
> - dev_dbg(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> + dev_info(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> wdt->regs, cdns_wdt_device->timeout,
> nowayout ? ", nowayout" : "");
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-08-14 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 7:39 [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters Michal Simek
2017-08-04 7:39 ` [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed Michal Simek
2017-08-04 13:47 ` Guenter Roeck
2017-08-04 13:56 ` Michal Simek
2017-08-14 14:47 ` Guenter Roeck [this message]
2017-08-04 13:45 ` [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters Guenter Roeck
2017-08-04 13:52 ` Michal Simek
2017-08-14 14:47 ` Guenter Roeck
2017-08-14 14:51 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814144750.GC14491@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®