mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Michal Simek <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
	<linux-watchdog@vger.kernel.org>,
	Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters
Date: Mon, 14 Aug 2017 16:51:28 +0200	[thread overview]
Message-ID: <37041da3-51f2-95c4-1d98-c0732b6a5082@xilinx.com> (raw)
In-Reply-To: <20170814144727.GB14491@roeck-us.net>

On 14.8.2017 16:47, Guenter Roeck wrote:
> On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote:
>> Give read access to module parameters to all and write access to root.
>> This change also improves driver error path testing.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
>> ---
>>
>> Please let me know what you think - I can use macros from stat.h if
>> required
>>
> You mean instead of 0644 ? That is discouraged nowadays.

yep and good.

Thanks,
Michal

      reply	other threads:[~2017-08-14 14:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04  7:39 Michal Simek
2017-08-04  7:39 ` [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed Michal Simek
2017-08-04 13:47   ` Guenter Roeck
2017-08-04 13:56     ` Michal Simek
2017-08-14 14:47   ` Guenter Roeck
2017-08-04 13:45 ` [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters Guenter Roeck
2017-08-04 13:52   ` Michal Simek
2017-08-14 14:47 ` Guenter Roeck
2017-08-14 14:51   ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37041da3-51f2-95c4-1d98-c0732b6a5082@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=monstr@monstr.eu \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®