* [PATCH] watchdog: max77620_wdt: constify platform_device_id
@ 2017-08-13 11:28 Arvind Yadav
2017-08-14 14:53 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-13 11:28 UTC (permalink / raw)
To: wim, linux; +Cc: linux-kernel, linux-watchdog
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/watchdog/max77620_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c
index 68c41fa..2c9f53e 100644
--- a/drivers/watchdog/max77620_wdt.c
+++ b/drivers/watchdog/max77620_wdt.c
@@ -201,7 +201,7 @@ static int max77620_wdt_remove(struct platform_device *pdev)
return 0;
}
-static struct platform_device_id max77620_wdt_devtype[] = {
+static const struct platform_device_id max77620_wdt_devtype[] = {
{ .name = "max77620-watchdog", },
{ },
};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] watchdog: max77620_wdt: constify platform_device_id
2017-08-13 11:28 [PATCH] watchdog: max77620_wdt: constify platform_device_id Arvind Yadav
@ 2017-08-14 14:53 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-08-14 14:53 UTC (permalink / raw)
To: Arvind Yadav; +Cc: wim, linux-kernel, linux-watchdog
On Sun, Aug 13, 2017 at 04:58:28PM +0530, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/max77620_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c
> index 68c41fa..2c9f53e 100644
> --- a/drivers/watchdog/max77620_wdt.c
> +++ b/drivers/watchdog/max77620_wdt.c
> @@ -201,7 +201,7 @@ static int max77620_wdt_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct platform_device_id max77620_wdt_devtype[] = {
> +static const struct platform_device_id max77620_wdt_devtype[] = {
> { .name = "max77620-watchdog", },
> { },
> };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-14 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-13 11:28 [PATCH] watchdog: max77620_wdt: constify platform_device_id Arvind Yadav
2017-08-14 14:53 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®