From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Colin King <colin.king@canonical.com>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type
Date: Tue, 15 Aug 2017 18:22:59 +0300 [thread overview]
Message-ID: <20170815152259.idjvtw5tdg24xj2o@mwanda> (raw)
In-Reply-To: <20170815143834.GL2369@lahna.fi.intel.com>
On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote:
> On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > req->response_type is being assigned the sizeof TB_CFG_PKG_RESET
> > and should actually be assigned TB_CFG_PKG_RESET. Fix this.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> IIRC I already acked this some time ago ;-)
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> BTW, you should CC Greg as he has been gathering Thunderbolt related
> patches. I added him now.
Yeah. I sent this patch on Jun 14. "[PATCH] thunderbolt: Fix reset
response_type" I didn't CC Greg, either. Someone should probably
update MAINTAINERS if Greg needs to get these emails.
Colin, could you please add Fixes tags to your patches? It helps me
investigate how bugs are introduced. I know we all had a long thread
and agreed to not add them if the patch probably doesn't fix a user
visible bug, but this one is clearly a bugfix.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-15 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:31 Colin King
2017-08-15 14:38 ` Mika Westerberg
2017-08-15 15:22 ` Dan Carpenter [this message]
2017-08-15 15:46 ` Colin Ian King
2017-08-16 8:54 ` [PATCH resend] thunderbolt: Fix reset response_type Dan Carpenter
2017-08-27 13:38 ` Mika Westerberg
2017-08-16 8:10 ` [PATCH] thunderbolt: fix incorrect value assigned to req->response_type Mika Westerberg
2017-08-16 16:13 ` Greg Kroah-Hartman
2017-08-17 9:39 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815152259.idjvtw5tdg24xj2o@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.noever@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®