From: Steven Rostedt <rostedt@goodmis.org>
To: Pratyush Anand <panand@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracer: hwlat: allow to be default bootup tracer
Date: Wed, 16 Aug 2017 10:28:03 -0400 [thread overview]
Message-ID: <20170816102803.06337f0b@gandalf.local.home> (raw)
In-Reply-To: <e7074fb64500370c2fbefd5503886f5e474cb9f6.1502451039.git.panand@redhat.com>
On Fri, 11 Aug 2017 17:01:21 +0530
Pratyush Anand <panand@redhat.com> wrote:
> hwlat is not a production kernel tracer, however it can be used to
> identify any HW latency issue during kernel boot as well.Therefore call
> init_hwlat_tracer() though core_initcall() so that we can pass
> ftrace=hwlat in kernel commandline parameter and we can have hwlat as
> default bootup tracer.
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> kernel/trace/trace_hwlat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c
> index d7c8e4ec3d9d..09f8f0950b6c 100644
> --- a/kernel/trace/trace_hwlat.c
> +++ b/kernel/trace/trace_hwlat.c
> @@ -630,4 +630,4 @@ __init static int init_hwlat_tracer(void)
>
> return 0;
> }
> -late_initcall(init_hwlat_tracer);
> +core_initcall(init_hwlat_tracer);
No that is not the right fix. hwlat tracer should not be called by core
init.
I already have a fix in linux-next. I'm doing some more code that needs
testing before I send it to Linus.
-- Steve
prev parent reply other threads:[~2017-08-16 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 11:31 Pratyush Anand
2017-08-16 14:28 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816102803.06337f0b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®