* [PATCH] tracer: hwlat: allow to be default bootup tracer
@ 2017-08-11 11:31 Pratyush Anand
2017-08-16 14:28 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Pratyush Anand @ 2017-08-11 11:31 UTC (permalink / raw)
To: rostedt, Ingo Molnar; +Cc: linux-kernel, Pratyush Anand
hwlat is not a production kernel tracer, however it can be used to
identify any HW latency issue during kernel boot as well.Therefore call
init_hwlat_tracer() though core_initcall() so that we can pass
ftrace=hwlat in kernel commandline parameter and we can have hwlat as
default bootup tracer.
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
kernel/trace/trace_hwlat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c
index d7c8e4ec3d9d..09f8f0950b6c 100644
--- a/kernel/trace/trace_hwlat.c
+++ b/kernel/trace/trace_hwlat.c
@@ -630,4 +630,4 @@ __init static int init_hwlat_tracer(void)
return 0;
}
-late_initcall(init_hwlat_tracer);
+core_initcall(init_hwlat_tracer);
--
2.9.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tracer: hwlat: allow to be default bootup tracer
2017-08-11 11:31 [PATCH] tracer: hwlat: allow to be default bootup tracer Pratyush Anand
@ 2017-08-16 14:28 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2017-08-16 14:28 UTC (permalink / raw)
To: Pratyush Anand; +Cc: Ingo Molnar, linux-kernel
On Fri, 11 Aug 2017 17:01:21 +0530
Pratyush Anand <panand@redhat.com> wrote:
> hwlat is not a production kernel tracer, however it can be used to
> identify any HW latency issue during kernel boot as well.Therefore call
> init_hwlat_tracer() though core_initcall() so that we can pass
> ftrace=hwlat in kernel commandline parameter and we can have hwlat as
> default bootup tracer.
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> kernel/trace/trace_hwlat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c
> index d7c8e4ec3d9d..09f8f0950b6c 100644
> --- a/kernel/trace/trace_hwlat.c
> +++ b/kernel/trace/trace_hwlat.c
> @@ -630,4 +630,4 @@ __init static int init_hwlat_tracer(void)
>
> return 0;
> }
> -late_initcall(init_hwlat_tracer);
> +core_initcall(init_hwlat_tracer);
No that is not the right fix. hwlat tracer should not be called by core
init.
I already have a fix in linux-next. I'm doing some more code that needs
testing before I send it to Linus.
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-16 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-11 11:31 [PATCH] tracer: hwlat: allow to be default bootup tracer Pratyush Anand
2017-08-16 14:28 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®