mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Meelis Roos <mroos@linux.ee>, Ingo Molnar <mingo@kernel.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: warning: objtool: ...: call without frame pointer save/setup; return with modified stack frame
Date: Thu, 17 Aug 2017 11:53:47 -0500	[thread overview]
Message-ID: <20170817165347.z4ipxyglu5vvocr2@treble> (raw)
In-Reply-To: <alpine.LRH.2.20.1708171606160.29402@math.ut.ee>

On Thu, Aug 17, 2017 at 04:09:58PM +0300, Meelis Roos wrote:
> Today I coticed the following objtool warnings when compiling 
> 4.13-rc5+git for my Atom 330 PC:
> 
> call without frame pointer save/setup
> return with modified stack frame
> 
> Examples (there is a lot more of them in practice):
> 
> arch/x86/kernel/smpboot.o: warning: objtool: arch_update_cpu_topology()+0x29: call without frame pointer save/setup
> arch/x86/kernel/smpboot.o: warning: objtool: native_smp_prepare_cpus()+0x530: return with modified stack frame
> 
> mm/vmalloc.o: warning: objtool: __get_vm_area()+0x26: call without frame pointer save/setup
> mm/vmalloc.o: warning: objtool: get_vm_area()+0x34: call without frame pointer save/setup
> 
> fs/debugfs/inode.o: warning: objtool: debugfs_initialized()+0x22: call without frame pointer save/setup
> fs/debugfs/inode.o: warning: objtool: debugfs_create_file()+0x20: call without frame pointer save/setup
> fs/debugfs/inode.o: warning: objtool: debugfs_create_file_unsafe()+0x20: call without frame pointer save/setup
> 
> mm/nobootmem.o: warning: objtool: __alloc_memory_core_early()+0xb2: return with modified stack frame

Hi Meelis,

Thanks for reporting this issue.  This has been already been fixed in
the tip tree with the following commit:

  5b8de48e82ba ("objtool: Fix '-mtune=atom' decoding support in objtool 2.0")

Ingo, would you be willing to put this patch in the 4.13 urgent queue?

-- 
Josh

      reply	other threads:[~2017-08-17 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 13:09 Meelis Roos
2017-08-17 16:53 ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817165347.z4ipxyglu5vvocr2@treble \
    --to=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®