From: Greg KH <gregkh@linuxfoundation.org>
To: Ashish Kalra <eashishkalra@gmail.com>
Cc: wsa@the-dreams.de, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
joe@perches.com
Subject: Re: [PATCH v2]staging: ks7010: fix styling WARNINGs
Date: Thu, 17 Aug 2017 10:58:50 -0700 [thread overview]
Message-ID: <20170817175850.GB5980@kroah.com> (raw)
In-Reply-To: <1501608336-9426-1-git-send-email-eashishkalra@gmail.com>
On Tue, Aug 01, 2017 at 06:25:36PM +0100, Ashish Kalra wrote:
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
>
> Trivial style changes. There are still "line over 80 characters"
> checkpatch.pl warnings, but I think they are best left alone as
> breaking these could hurt readability
> v2: Updated Patch as per review comments recievd
Why is all of this stuff below the signed-off-by line?
Please fix this up properly, and read the documentation for how to
submit a patch in Documentation/SubmittingPatches.
thanks,
greg k-h
next prev parent reply other threads:[~2017-08-17 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 2:20 [PATCH] Removing Check Errors with checkpatch.pl, Converting from macro to function call Ashish Kalra
2017-08-01 0:25 ` Joe Perches
2017-07-31 3:15 ` [PATCH] staging: ks7010: fix styling WARNINGs Ashish Kalra
2017-08-01 1:18 ` Greg KH
2017-08-01 4:29 ` kbuild test robot
2017-08-01 4:31 ` kbuild test robot
2017-08-01 16:11 ` Ashish Kalra
2017-08-01 16:22 ` Joe Perches
2017-08-01 17:25 ` [PATCH v2]staging: " Ashish Kalra
2017-08-17 17:58 ` Greg KH [this message]
2017-08-01 20:28 ` [PATCH] staging: " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817175850.GB5980@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=eashishkalra@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®