* [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C
@ 2017-08-21 10:03 Dmitry Fleytman
2017-08-24 7:58 ` Kai-Heng Feng
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Fleytman @ 2017-08-21 10:03 UTC (permalink / raw)
Cc: Dmitry Fleytman, Greg Kroah-Hartman, Sandeep Singh,
Samuel Thibault, Shyam Sundar S K, Devin Heitmueller,
Lukáš Lalinský,
Kai-Heng Feng, linux-usb, linux-kernel
Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
introduced quirk to workaround an issue with some Logitech webcams.
Apparently model C920-C has the same issue so applying
the same quirk as well.
See aforementioned commit message for detailed explanation of the problem.
Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
---
drivers/usb/core/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 574da2b..36d4841 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Logitech HD Pro Webcams C920 and C930e */
{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
/* Logitech ConferenceCam CC3000e */
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C
2017-08-21 10:03 [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C Dmitry Fleytman
@ 2017-08-24 7:58 ` Kai-Heng Feng
2017-08-25 7:41 ` Dmitry Fleytman
0 siblings, 1 reply; 3+ messages in thread
From: Kai-Heng Feng @ 2017-08-24 7:58 UTC (permalink / raw)
To: Dmitry Fleytman
Cc: Greg Kroah-Hartman, Sandeep Singh, Samuel Thibault,
Shyam Sundar S K, Devin Heitmueller,
Lukáš Lalinský,
USB list, LKML
On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman <dmitry@daynix.com> wrote:
> Commit e0429362ab15
> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
> introduced quirk to workaround an issue with some Logitech webcams.
>
> Apparently model C920-C has the same issue so applying
> the same quirk as well.
I think it's better to also mention "C920-C" in the comment section.
>
> See aforementioned commit message for detailed explanation of the problem.
>
> Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
> ---
> drivers/usb/core/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 574da2b..36d4841 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> /* Logitech HD Pro Webcams C920 and C930e */
> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
> + { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
>
> /* Logitech ConferenceCam CC3000e */
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C
2017-08-24 7:58 ` Kai-Heng Feng
@ 2017-08-25 7:41 ` Dmitry Fleytman
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Fleytman @ 2017-08-25 7:41 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: Greg Kroah-Hartman, Sandeep Singh, Samuel Thibault,
Shyam Sundar S K, Devin Heitmueller,
Lukáš Lalinský,
USB list, LKML
> On 24 Aug 2017, at 10:58 AM, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>
> On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman <dmitry@daynix.com> wrote:
>> Commit e0429362ab15
>> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
>> introduced quirk to workaround an issue with some Logitech webcams.
>>
>> Apparently model C920-C has the same issue so applying
>> the same quirk as well.
>
> I think it's better to also mention "C920-C" in the comment section.
I agree. See v2 (just sent).
Thanks,
Dmitry
>
>>
>> See aforementioned commit message for detailed explanation of the problem.
>>
>> Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
>> ---
>> drivers/usb/core/quirks.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 574da2b..36d4841 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
>>
>> /* Logitech HD Pro Webcams C920 and C930e */
>> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
>> + { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
>> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
>>
>> /* Logitech ConferenceCam CC3000e */
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-25 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-21 10:03 [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C Dmitry Fleytman
2017-08-24 7:58 ` Kai-Heng Feng
2017-08-25 7:41 ` Dmitry Fleytman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®