From: "Luck, Tony" <tony.luck@intel.com>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources
Date: Tue, 22 Aug 2017 09:03:06 -0700 [thread overview]
Message-ID: <20170822160305.o4ceuqjnuy4drgxb@intel.com> (raw)
In-Reply-To: <BN6PR1201MB013138E0E32481E623C35715F8840@BN6PR1201MB0131.namprd12.prod.outlook.com>
On Tue, Aug 22, 2017 at 02:04:27PM +0000, Ghannam, Yazen wrote:
> > *einj_get_trigger_parameter_region(
> > ((char *)trigger_tab + sizeof(struct acpi_einj_trigger));
> > for (i = 0; i < trigger_tab->entry_count; i++) {
> > if (entry->action == ACPI_EINJ_TRIGGER_ERROR &&
> > - entry->instruction == ACPI_EINJ_WRITE_REGISTER_VALUE &&
> > entry->register_region.space_id ==
> > ACPI_ADR_SPACE_SYSTEM_MEMORY &&
> > (entry->register_region.address & param2) == (param1 &
> > param2))
Maybe you should add the other instruction types that make sense
here (ACPI_EINJ_READ_REGISTER, ACPI_EINJ_READ_REGISTER_VALUE and
ACPI_EINJ_WRITE_REGISTER) as a sanity check against the BIOS
giving you an action in the trigger table that doesn't involve
a memory access?
-Tony
next prev parent reply other threads:[~2017-08-22 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:58 Yazen Ghannam
2017-08-22 14:04 ` Ghannam, Yazen
2017-08-22 16:03 ` Luck, Tony [this message]
2017-08-23 16:37 ` Ghannam, Yazen
2017-08-23 16:52 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822160305.o4ceuqjnuy4drgxb@intel.com \
--to=tony.luck@intel.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®