From: "Luck, Tony" <tony.luck@intel.com>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources
Date: Wed, 23 Aug 2017 09:52:46 -0700 [thread overview]
Message-ID: <20170823165245.52437iccij6sm4ta@intel.com> (raw)
In-Reply-To: <BN6PR1201MB013106200C118FC6336017C8F8850@BN6PR1201MB0131.namprd12.prod.outlook.com>
On Wed, Aug 23, 2017 at 04:37:43PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Luck, Tony [mailto:tony.luck@intel.com]
> > Maybe you should add the other instruction types that make sense here
> > (ACPI_EINJ_READ_REGISTER, ACPI_EINJ_READ_REGISTER_VALUE and
> > ACPI_EINJ_WRITE_REGISTER) as a sanity check against the BIOS giving you an
> > action in the trigger table that doesn't involve a memory access?
> >
>
> Yes, in that case we can do:
> entry->instruction <= ACPI_EINJ_WRITE_REGISTER_VALUE
>
> That would cover all the memory access instructions and protect against invalid
> instructions.
>
> How does that sound?
Perfect.
Acked-by: Tony Luck <tony.luck@intel.com>
-Tony
prev parent reply other threads:[~2017-08-23 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:58 Yazen Ghannam
2017-08-22 14:04 ` Ghannam, Yazen
2017-08-22 16:03 ` Luck, Tony
2017-08-23 16:37 ` Ghannam, Yazen
2017-08-23 16:52 ` Luck, Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823165245.52437iccij6sm4ta@intel.com \
--to=tony.luck@intel.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®