From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry
Date: Tue, 22 Aug 2017 22:12:15 +0200 [thread overview]
Message-ID: <20170822201215.wbpioc7vbse4ajja@flea.home> (raw)
In-Reply-To: <20170822061742.40869-3-icenowy@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote:
> +®_vcc5v0 {
> + gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
> + enable-active-high;
> +};
Same thing here, you're not using that regulator anywhere. You don't
even use any of the regulators in sunxi-common-regulators.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-08-22 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 6:17 [PATCH 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Icenowy Zheng
2017-08-22 6:17 ` [PATCH 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra Icenowy Zheng
2017-08-22 20:10 ` Maxime Ripard
2017-08-23 0:58 ` Icenowy Zheng
2017-08-22 6:17 ` [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry Icenowy Zheng
2017-08-22 20:12 ` Maxime Ripard [this message]
2017-08-23 5:46 ` Icenowy Zheng
2017-08-23 14:31 ` Maxime Ripard
2017-08-22 20:05 ` [PATCH 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Maxime Ripard
2017-08-23 0:56 ` Icenowy Zheng
2017-08-23 11:56 ` icenowy
2017-08-23 14:35 ` Maxime Ripard
2017-08-23 15:13 ` icenowy
2017-08-24 6:07 ` Maxime Ripard
2017-08-24 6:25 ` [linux-sunxi] " icenowy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822201215.wbpioc7vbse4ajja@flea.home \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®