* [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
@ 2017-08-17 11:55 laurentiu.tudor
2017-08-23 1:40 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: laurentiu.tudor @ 2017-08-17 11:55 UTC (permalink / raw)
To: gregkh, stuyoder
Cc: devel, linux-kernel, agraf, ioana.ciornei, linux-arm-kernel,
Laurentiu Tudor
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Throughout the driver we use == 0 / != 0 to check strcmp() returns except
this place, so fix it.
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 485abad..06df528 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,7 +29,7 @@ static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
struct fsl_mc_obj_desc *obj_desc)
{
return mc_dev->obj_desc.id == obj_desc->id &&
- !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+ strcmp(mc_dev->obj_desc.type, obj_desc->type) == 0;
}
--
2.9.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
2017-08-17 11:55 [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns laurentiu.tudor
@ 2017-08-23 1:40 ` Greg KH
2017-08-23 2:33 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2017-08-23 1:40 UTC (permalink / raw)
To: laurentiu.tudor
Cc: stuyoder, devel, linux-kernel, agraf, ioana.ciornei, linux-arm-kernel
On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> this place, so fix it.
You will just get someone else fixing it as it is not what checkpatch
recommends, so just leave it as-is please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
2017-08-23 1:40 ` Greg KH
@ 2017-08-23 2:33 ` Joe Perches
2017-08-23 5:38 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-08-23 2:33 UTC (permalink / raw)
To: Greg KH, laurentiu.tudor
Cc: stuyoder, devel, linux-kernel, agraf, ioana.ciornei, linux-arm-kernel
On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
>
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.
No. That's not correct.
checkpatch does not make a recommendation about
style use with the strcmp family of functions.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
2017-08-23 2:33 ` Joe Perches
@ 2017-08-23 5:38 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-08-23 5:38 UTC (permalink / raw)
To: Joe Perches
Cc: laurentiu.tudor, stuyoder, devel, linux-kernel, agraf,
ioana.ciornei, linux-arm-kernel
On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote:
> On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> > On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> > > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > >
> > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > > this place, so fix it.
> >
> > You will just get someone else fixing it as it is not what checkpatch
> > recommends, so just leave it as-is please.
>
> No. That's not correct.
>
> checkpatch does not make a recommendation about
> style use with the strcmp family of functions.
Ah, ok, nevermind then...
Laurentiu, can you resend this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-23 5:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-17 11:55 [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns laurentiu.tudor
2017-08-23 1:40 ` Greg KH
2017-08-23 2:33 ` Joe Perches
2017-08-23 5:38 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome