* Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__ [not found] <599d2f67.8b43ca0a.bef3d.273dSMTPIN_ADDED_BROKEN@mx.google.com> @ 2017-08-23 23:21 ` Greg Kroah-Hartman 0 siblings, 0 replies; 2+ messages in thread From: Greg Kroah-Hartman @ 2017-08-23 23:21 UTC (permalink / raw) To: Shurong Zhang Cc: Jens Frederich, Daniel Drake, Jon Nettleton, devel, linux-kernel On Wed, Aug 23, 2017 at 03:31:46PM +0800, Shurong Zhang wrote: > Replace hard-coded function names in strings with "%s", __func__ > in the olpc_dcon.c file. Issue found by checkpatch.pl. > > Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com> > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c > index f7f3a78..3a8d99f 100644 > --- a/drivers/staging/olpc_dcon/olpc_dcon.c > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c > @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev, > if (ret) > return ret; > > - pr_info("dcon_freeze_store: %lu\n", output); > + pr_info("%s: %lu\n", __func__, output); Should just be deleted entirely, like Dan says. ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <599d2f8c.d600630a.2393.4573SMTPIN_ADDED_BROKEN@mx.google.com>]
* Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__ [not found] <599d2f8c.d600630a.2393.4573SMTPIN_ADDED_BROKEN@mx.google.com> @ 2017-08-23 11:12 ` Dan Carpenter 0 siblings, 0 replies; 2+ messages in thread From: Dan Carpenter @ 2017-08-23 11:12 UTC (permalink / raw) To: Shurong Zhang Cc: Jens Frederich, Daniel Drake, Jon Nettleton, Greg Kroah-Hartman, devel, linux-kernel On Wed, Aug 23, 2017 at 03:31:46PM +0800, Shurong Zhang wrote: > Replace hard-coded function names in strings with "%s", __func__ > in the olpc_dcon.c file. Issue found by checkpatch.pl. > > Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com> > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c > index f7f3a78..3a8d99f 100644 > --- a/drivers/staging/olpc_dcon/olpc_dcon.c > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c > @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev, > if (ret) > return ret; > > - pr_info("dcon_freeze_store: %lu\n", output); > + pr_info("%s: %lu\n", __func__, output); This printk doesn't really add anything worthwhile. Just delete it. regards, dan carpenter ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-23 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <599d2f67.8b43ca0a.bef3d.273dSMTPIN_ADDED_BROKEN@mx.google.com>
2017-08-23 23:21 ` [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__ Greg Kroah-Hartman
[not found] <599d2f8c.d600630a.2393.4573SMTPIN_ADDED_BROKEN@mx.google.com>
2017-08-23 11:12 ` Dan Carpenter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®